Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax coloring and more compact diagram #34080

Merged
merged 2 commits into from
Jun 28, 2016
Merged

Syntax coloring and more compact diagram #34080

merged 2 commits into from
Jun 28, 2016

Conversation

royalstream
Copy link
Contributor

@royalstream royalstream commented Jun 4, 2016

Two cosmetic improvements:

  • New content was added a few days ago to the Closures chapter but it was missing rust's syntax coloring.
  • Also, in the Crates and Modules chapter, a diagram was improved to be more symmetric and to take less space.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

Thank you! I am so sorry this slipped through the cracks.

@bors
Copy link
Contributor

bors commented Jun 27, 2016

📌 Commit e9f6c0f has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 27, 2016
… r=steveklabnik

Syntax coloring and more compact diagram

Two cosmetic improvements:
- New content was added a few days ago to the **Closures** chapter but it was missing rust's syntax coloring.
- Also, in the **Crates and Modules** chapter, a diagram was improved to be more symmetric and to take less space.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 27, 2016
… r=steveklabnik

Syntax coloring and more compact diagram

Two cosmetic improvements:
- New content was added a few days ago to the **Closures** chapter but it was missing rust's syntax coloring.
- Also, in the **Crates and Modules** chapter, a diagram was improved to be more symmetric and to take less space.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 28, 2016
… r=steveklabnik

Syntax coloring and more compact diagram

Two cosmetic improvements:
- New content was added a few days ago to the **Closures** chapter but it was missing rust's syntax coloring.
- Also, in the **Crates and Modules** chapter, a diagram was improved to be more symmetric and to take less space.
bors added a commit that referenced this pull request Jun 28, 2016
@bors bors merged commit e9f6c0f into rust-lang:master Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants