-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise wording in Rc documentation. #34097
Conversation
The term "thread-local" has a widely-accepted meaning which is not the meaning it's used for here.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks, good catch! For the sake of non-concurrency experts, I wonder if we can take your wording, but then also add a clarification -- "usable only within a single thread", or something like that. |
I'm not sure this new wording is better. I think a longer one would fit the most. |
What's the status of this? |
@apasel422: No news from @arbitrary-cat, so no idea... |
How's that? |
Looks great to me, thanks for coming back to this! @bors: r+ rollup |
📌 Commit 46e7c9e has been approved by |
Revise wording in Rc documentation. The term "thread-local" has a widely accepted meaning which is not the meaning it's used for here.
support pub(restricted) in thread_local! (round 2) Resurrected #40984 now that the issue blocking it was fixed. Original description: `pub(restricted)` was stabilized in #40556 so let's go! Here is a [playground](https://play.rust-lang.org/?gist=f55f32f164a6ed18c219fec8f8293b98&version=nightly&backtrace=1). I changed the interface of `__thread_local_inner!`, which is supposedly unstable but this is not checked for macros (#34097 cc @petrochenkov @jseyfried), so this may be an issue.
The term "thread-local" has a widely accepted meaning which is not
the meaning it's used for here.