Visit statement and expression attributes in the AST visitor #34199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this move these attributes early enough to support |
|
@bors: r+ |
|
📌 Commit 8475a4b has been approved by |
bors
added a commit
that referenced
this pull request
Jun 10, 2016
Visit statement and expression attributes in the AST visitor Currently, these attributes are not visited, so they are not gated feature checked in the post expansion visitor. This only affects crates using `#![feature(stmt_expr_attributes)]`. r? @nrc
|
💔 Test failed - auto-mac-32-opt |
|
@bors retry force |
No -- it looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, these attributes are not visited, so they are not gated feature checked in the post expansion visitor. This only affects crates using
#![feature(stmt_expr_attributes)].r? @nrc