Skip to content

don't generate drop ladder steps for fields that don't need dropping #34290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2016
Merged

don't generate drop ladder steps for fields that don't need dropping #34290

merged 2 commits into from
Jun 16, 2016

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Jun 15, 2016

cc @eddyb

This should help with #34166

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor Author

arielb1 commented Jun 15, 2016

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned pnkfelix Jun 15, 2016
@eddyb
Copy link
Member

eddyb commented Jun 15, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 15, 2016

📌 Commit 15799b8 has been approved by eddyb

@arielb1
Copy link
Contributor Author

arielb1 commented Jun 15, 2016

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented Jun 15, 2016

📌 Commit 2960bc8 has been approved by eddyb

@Manishearth Manishearth mentioned this pull request Jun 15, 2016
Merged
bors added a commit that referenced this pull request Jun 16, 2016
@bors
Auto merge of #34291 - Manishearth:rollup, r=Manishearth
58adb07 
Rollup of 4 pull requests

- Successful merges: #34207, #34268, #34270, #34290
- Failed merges:
@arielb1
Copy link
Contributor Author

arielb1 commented Jun 16, 2016

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented Jun 16, 2016

📌 Commit 68129a6 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Jun 16, 2016

⌛ Testing commit 68129a6 with merge a479a6a...

bors added a commit that referenced this pull request Jun 16, 2016
@bors
Auto merge of #34290 - arielb1:short-ladder, r=eddyb
a479a6a 
don't generate drop ladder steps for fields that don't need dropping

cc @eddyb

This should help with #34166
@bors
Copy link
Collaborator

bors commented Jun 16, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit 68129a6 into rust-lang:master Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arielb1 @rust-highfive @eddyb @bors @pnkfelix