Pretty-print attributes on tuple structs and add tests #34310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
Can you make the same change to the HIR pretty printer too please? |
|
☔ The latest upstream changes (presumably #34315) made this pull request unmergeable. Please resolve the merge conflicts. |
This adds support to the pretty printer to print attributes added to tuple struct elements. Furthermore, it adds a test that makes sure we will print attributes on all variant data types.
erickt
force-pushed
the
tuple-struct-attrs
branch
from
5f41f71 to
9de2de1
Compare
|
@nrc: done! |
|
@bors: r+ rollup |
|
📌 Commit 9de2de1 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 18, 2016
Pretty-print attributes on tuple structs and add tests This adds support to the pretty printer to print attributes added to tuple struct elements. Furthermore, it adds a test that makes sure we will print attributes on all variant data types.
erickt
added a commit
to erickt/syntex
that referenced
this pull request
Jun 21, 2016
This backports rust-lang/rust#34310, which has not yet landed in a nightly yet, so we can't yet sync with the upstream libsyntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to the pretty printer to print attributes added to tuple struct elements. Furthermore, it adds a test that makes sure we will print attributes on all variant data types.