Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Fix up stabilization discrepancies #34399

Merged
merged 1 commit into from
Jun 24, 2016

Conversation

alexcrichton
Copy link
Member

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 21, 2016
@brson
Copy link
Contributor

brson commented Jun 21, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Jun 21, 2016

📌 Commit b41c496 has been approved by brson

@Manishearth
Copy link
Member

src/libstd/os/linux/raw.rs:27:1: 27:30 error: An API can't be stabilized after it is deprecated

src/libstd/os/linux/raw.rs:27 pub type pthread_t = c_ulong;

                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/libstd/sys/unix/ext/raw.rs:27:1: 27:39 error: An API can't be stabilized after it is deprecated

src/libstd/sys/unix/ext/raw.rs:27 pub use sys::platform::raw::pthread_t;

                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: aborting due to 2 previous errors

@bors r-

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Jun 22, 2016

📌 Commit 3398312 has been approved by brson

@tamird
Copy link
Contributor

tamird commented Jun 23, 2016

src/libcollections/lib.rs:52:12: 52:20 error: unused or unknown feature
src/libcollections/lib.rs:52 #![feature(str_char)]
                                        ^~~~~~~~
src/libcollections/lib.rs:30:31: 30:39 note: lint level defined here
src/libcollections/lib.rs:30 #![cfg_attr(not(stage0), deny(warnings))]
                                                           ^~~~~~~~
error: aborting due to previous error

@@ -20,7 +20,8 @@

use os::raw::c_long;

#[unstable(feature = "pthread_t", issue = "29791")] pub type pthread_t = c_long;
#[stable(feature = "pthread_t", since = "1.8.0")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be 1.9.0?

@bors
Copy link
Contributor

bors commented Jun 23, 2016

⌛ Testing commit 3398312 with merge e86bf88...

@bors
Copy link
Contributor

bors commented Jun 23, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

* Remove the deprecated `CharRange` type which was forgotten to be removed
  awhile back.
* Stabilize the `os::$platform::raw::pthread_t` type which was intended to be
  stabilized as part of rust-lang#32804
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Jun 23, 2016

📌 Commit c3e8c17 has been approved by brson

@bors
Copy link
Contributor

bors commented Jun 23, 2016

⌛ Testing commit c3e8c17 with merge 63907e4...

@bors
Copy link
Contributor

bors commented Jun 23, 2016

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member Author

@bors: retry

On Thu, Jun 23, 2016 at 3:54 PM, bors notifications@github.com wrote:

💔 Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/9565


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34399 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95CPtDWCLyySu0CGLsVNSx-er8XEmks5qOw6sgaJpZM4I6-KE
.

@bors
Copy link
Contributor

bors commented Jun 24, 2016

⌛ Testing commit c3e8c17 with merge 7189ae3...

bors added a commit that referenced this pull request Jun 24, 2016
std: Fix up stabilization discrepancies

* Remove the deprecated `CharRange` type which was forgotten to be removed
  awhile back.
* Stabilize the `os::$platform::raw::pthread_t` type which was intended to be
  stabilized as part of #32804
@bors bors merged commit c3e8c17 into rust-lang:master Jun 24, 2016
@alexcrichton alexcrichton deleted the issue-audit branch June 28, 2016 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants