std: Stabilize APIs for the 1.11.0 release #34530

alexcrichton · 2016-06-28T17:12:23Z

Although the set of APIs being stabilized this release is relatively small, the
trains keep going! Listed below are the APIs in the standard library which have
either transitioned from unstable to stable or those from unstable to
deprecated.

Stable

BTreeMap::{append, split_off}
BTreeSet::{append, split_off}
Cell::get_mut
RefCell::get_mut
BinaryHeap::append
{f32, f64}::{to_degrees, to_radians} - libcore stabilizations mirroring past
libstd stabilizations
Iterator::sum
Iterator::product

Deprecated

{f32, f64}::next_after
{f32, f64}::integer_decode
{f32, f64}::ldexp
{f32, f64}::frexp
num::One
num::Zero

Added APIs (all unstable)

iter::Sum
iter::Product
iter::Step - a few methods were added to accomodate deprecation of One/Zero

Removed APIs

From<Range<T>> for RangeInclusive<T> - everything about RangeInclusive is
unstable

Closes #27739
Closes #27752
Closes #32526
Closes #33444
Closes #34152
cc #34529 (new tracking issue)

rust-highfive · 2016-06-28T17:12:28Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2016-06-28T17:13:02Z

cc @rust-lang/libs, the deprecation of Zero and One had some particularly nasty fallout, but not totally unreasonable. The Step trait is getting farther and farther away from stabilization though in the implementation of iteration for a few range types.

brson · 2016-06-28T18:07:29Z

@alexcrichton Your comments about the fallout and unlikelihood of stabilizing Step are worrying. Are we digging ourselves into a hole with these unstable traits that stable APIs depend on? Are you still confident about stabilizing sum/product (sorry to keep harping on this)?

alexcrichton · 2016-06-28T18:51:17Z

I'm personally still confident in stabilizing the sum/product methods, but yes we're digging ourselves into a hole with Step and the various iterator implementations it's used for. I believe step_by is still unstable but it's used for the iterators on Range and RangeFrom, which are indeed stable.

The methods of Step used by the stable impl blocks are very small and minor (one could easily see stabilizing that triat). So I'm not as un-confident now that I read into it.

This would entail killing step_by and rethinking RangeInclusive iteration, however.

SimonSapin · 2016-06-29T15:15:43Z

src/libcore/iter/traits.rs

+        impl Sum for $a {
+            fn sum<I: Iterator<Item=$a>>(iter: I) -> $a {
+                iter.fold(0, |a, b| {
+                    a.checked_add(b).expect("overflow in sum")


Why always check rather than use + with its configurable behavior?

With MIR we unfortunately don't have that luxury as whether the arithmetic is checked or not is encoded into the MIR, not generated at trans time.

Is that relevant because libcore is usually distributed pre-compiled? If so it’s worth a source comment at least, and maybe a doc-comment.

The overflow behavior is documented on the sum/product methods, and yes this is due to it being distributed as a compiled artifact.

aturon · 2016-07-01T20:03:47Z

One stability nit, otherwise r=me

alexcrichton · 2016-07-01T21:55:34Z

@bors: r=aturon

bors · 2016-07-01T21:55:35Z

📌 Commit 71dec1b has been approved by aturon

bors · 2016-07-02T13:27:07Z

⌛ Testing commit 71dec1b with merge 9ef8ff8...

bors · 2016-07-02T13:50:58Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

arielb1 · 2016-07-02T14:11:21Z

> C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libcore\iter\range.rs:207:17: 207:26 error: comparison is useless due to type limits
> C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libcore\iter\range.rs:207                 *self < 0
> C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libcore\iter\range.rs:247:1: 247:32 note: in this expansion of step_impl_no_between! (defined in C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libcore\iter\range.rs)
> C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libcore\lib.rs:60:31: 60:39 note: lint level defined here
> C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libcore\lib.rs:60 #![cfg_attr(not(stage0), deny(warnings))]

alexcrichton · 2016-07-02T17:28:18Z

@bors: r=aturon

bors · 2016-07-02T17:28:19Z

📌 Commit 7cfcb4a has been approved by aturon

bors · 2016-07-02T22:13:54Z

⌛ Testing commit 7cfcb4a with merge f632159...

bors · 2016-07-02T22:37:05Z

💔 Test failed - auto-win-msvc-64-cargotest

arielb1 · 2016-07-03T08:54:38Z

C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\num/f32.rs:114:26: 114:36 error: use of deprecated item: never really came to fruition and easily implementable outside the standard library
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\num/f32.rs:114             let (a, b) = f64::frexp(x as f64);
                                                                                                 ^~~~~~~~~~
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289:31: 289:39 note: lint level defined here
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289 #![cfg_attr(not(stage0), deny(warnings))]
                                                                                                  ^~~~~~~~
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\num/f32.rs:121:13: 121:23 error: use of deprecated item: never really came to fruition and easily implementable outside the standard library
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\num/f32.rs:121             f64::ldexp(x as f64, n as isize) as c_float
                                                                                    ^~~~~~~~~~
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289:31: 289:39 note: lint level defined here
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289 #![cfg_attr(not(stage0), deny(warnings))]
                                                                                                  ^~~~~~~~
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\sys/windows/mod.rs:17:5: 17:14 error: use of deprecated item: no longer used for Iterator::sum
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\sys/windows/mod.rs:17 use num::Zero;
                                                                                   ^~~~~~~~~
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289:31: 289:39 note: lint level defined here
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289 #![cfg_attr(not(stage0), deny(warnings))]
                                                                                                  ^~~~~~~~
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\sys/windows\net.rs:20:5: 20:13 error: unused import
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\sys/windows\net.rs:20 use ops::Neg;
                                                                                   ^~~~~~~~
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289:31: 289:39 note: lint level defined here
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289 #![cfg_attr(not(stage0), deny(warnings))]
                                                                                                  ^~~~~~~~
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\sys/windows/mod.rs:181:23: 181:27 error: use of deprecated item: no longer used for Iterator::sum
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\sys/windows/mod.rs:181 fn cvt<I: PartialEq + Zero>(i: I) -> io::Result<I> {
                                                                                                      ^~~~
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289:31: 289:39 note: lint level defined here
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289 #![cfg_attr(not(stage0), deny(warnings))]
                                                                                                  ^~~~~~~~
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\sys/windows/mod.rs:182:13: 182:20 error: use of deprecated item: no longer used for Iterator::sum
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\sys/windows/mod.rs:182     if i == I::zero() {
                                                                                            ^~~~~~~
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289:31: 289:39 note: lint level defined here
C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libstd\lib.rs:289 #![cfg_attr(not(stage0), deny(warnings))]

Although the set of APIs being stabilized this release is relatively small, the trains keep going! Listed below are the APIs in the standard library which have either transitioned from unstable to stable or those from unstable to deprecated. Stable * `BTreeMap::{append, split_off}` * `BTreeSet::{append, split_off}` * `Cell::get_mut` * `RefCell::get_mut` * `BinaryHeap::append` * `{f32, f64}::{to_degrees, to_radians}` - libcore stabilizations mirroring past libstd stabilizations * `Iterator::sum` * `Iterator::product` Deprecated * `{f32, f64}::next_after` * `{f32, f64}::integer_decode` * `{f32, f64}::ldexp` * `{f32, f64}::frexp` * `num::One` * `num::Zero` Added APIs (all unstable) * `iter::Sum` * `iter::Product` * `iter::Step` - a few methods were added to accomodate deprecation of One/Zero Removed APIs * `From<Range<T>> for RangeInclusive<T>` - everything about `RangeInclusive` is unstable Closes rust-lang#27739 Closes rust-lang#27752 Closes rust-lang#32526 Closes rust-lang#33444 Closes rust-lang#34152 cc rust-lang#34529 (new tracking issue)

alexcrichton · 2016-07-03T17:49:07Z

@bors: r=aturon

bors · 2016-07-03T17:49:08Z

📌 Commit 3016626 has been approved by aturon

bors · 2016-07-03T21:33:56Z

⌛ Testing commit 3016626 with merge 696b703...

std: Stabilize APIs for the 1.11.0 release Although the set of APIs being stabilized this release is relatively small, the trains keep going! Listed below are the APIs in the standard library which have either transitioned from unstable to stable or those from unstable to deprecated. Stable * `BTreeMap::{append, split_off}` * `BTreeSet::{append, split_off}` * `Cell::get_mut` * `RefCell::get_mut` * `BinaryHeap::append` * `{f32, f64}::{to_degrees, to_radians}` - libcore stabilizations mirroring past libstd stabilizations * `Iterator::sum` * `Iterator::product` Deprecated * `{f32, f64}::next_after` * `{f32, f64}::integer_decode` * `{f32, f64}::ldexp` * `{f32, f64}::frexp` * `num::One` * `num::Zero` Added APIs (all unstable) * `iter::Sum` * `iter::Product` * `iter::Step` - a few methods were added to accomodate deprecation of One/Zero Removed APIs * `From<Range<T>> for RangeInclusive<T>` - everything about `RangeInclusive` is unstable Closes #27739 Closes #27752 Closes #32526 Closes #33444 Closes #34152 cc #34529 (new tracking issue)

bors · 2016-07-04T01:17:34Z

rust-highfive assigned aturon Jun 28, 2016

alexcrichton force-pushed the stabilize-1.11 branch 2 times, most recently from e0aa055 to 71dec1b Compare June 28, 2016 20:17

SimonSapin reviewed Jun 29, 2016
View reviewed changes

alexcrichton force-pushed the stabilize-1.11 branch from 71dec1b to 7cfcb4a Compare July 2, 2016 17:28

alexcrichton force-pushed the stabilize-1.11 branch from 7cfcb4a to 3016626 Compare July 3, 2016 17:49

bors merged commit 3016626 into rust-lang:master Jul 4, 2016

zackmdavis mentioned this pull request Jul 4, 2016

Passing by zackmdavis/Leafline#21

Closed

alexcrichton deleted the stabilize-1.11 branch July 5, 2016 14:53

mcarton mentioned this pull request Jul 9, 2016

lint for more unstable functions: rust-lang/rust-clippy#624

Closed

liigo mentioned this pull request Jul 28, 2016

rename std::num::Zero and std::num::One #13699

Closed

eddyb mentioned this pull request Aug 31, 2016

Silent overflow on debug beta/nightly #36110

Closed

kennytm mentioned this pull request Jun 19, 2018

Change RangeInclusive to a three-field struct. #51622

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

std: Stabilize APIs for the 1.11.0 release #34530

std: Stabilize APIs for the 1.11.0 release #34530

alexcrichton commented Jun 28, 2016

rust-highfive commented Jun 28, 2016

alexcrichton commented Jun 28, 2016

brson commented Jun 28, 2016 •

edited

Loading

alexcrichton commented Jun 28, 2016

SimonSapin Jun 29, 2016

alexcrichton Jun 29, 2016

SimonSapin Jun 30, 2016

alexcrichton Jun 30, 2016

aturon commented Jul 1, 2016

alexcrichton commented Jul 1, 2016

bors commented Jul 1, 2016

bors commented Jul 2, 2016

bors commented Jul 2, 2016

arielb1 commented Jul 2, 2016 •

edited

Loading

alexcrichton commented Jul 2, 2016

bors commented Jul 2, 2016

bors commented Jul 2, 2016

bors commented Jul 2, 2016

arielb1 commented Jul 3, 2016

alexcrichton commented Jul 3, 2016

bors commented Jul 3, 2016

bors commented Jul 3, 2016

bors commented Jul 4, 2016

std: Stabilize APIs for the 1.11.0 release #34530

std: Stabilize APIs for the 1.11.0 release #34530

Conversation

alexcrichton commented Jun 28, 2016

rust-highfive commented Jun 28, 2016

alexcrichton commented Jun 28, 2016

brson commented Jun 28, 2016 • edited Loading

alexcrichton commented Jun 28, 2016

SimonSapin Jun 29, 2016

Choose a reason for hiding this comment

alexcrichton Jun 29, 2016

Choose a reason for hiding this comment

SimonSapin Jun 30, 2016

Choose a reason for hiding this comment

alexcrichton Jun 30, 2016

Choose a reason for hiding this comment

aturon commented Jul 1, 2016

alexcrichton commented Jul 1, 2016

bors commented Jul 1, 2016

bors commented Jul 2, 2016

bors commented Jul 2, 2016

arielb1 commented Jul 2, 2016 • edited Loading

alexcrichton commented Jul 2, 2016

bors commented Jul 2, 2016

bors commented Jul 2, 2016

bors commented Jul 2, 2016

arielb1 commented Jul 3, 2016

alexcrichton commented Jul 3, 2016

bors commented Jul 3, 2016

bors commented Jul 3, 2016

bors commented Jul 4, 2016

brson commented Jun 28, 2016 •

edited

Loading

arielb1 commented Jul 2, 2016 •

edited

Loading