Skip to content

Backport #34141 to beta #34533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2016
Merged

Backport #34141 to beta #34533

merged 1 commit into from
Jun 28, 2016

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Jun 28, 2016

Didn't apply cleanly, but @eddyb mentioned it was ok to just trash all the trans updates, so this just changes old trans.

Beta backport of #34141

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@alexcrichton
Copy link
Member Author

To clarify, when backporting the commit from #34141, there were only conflicts in src/librustc_trans/mir/block.rs. I threw away all of those conflicts in favor of the code that was originally there. All other changes in other files applied cleanly, however, and are included here. I've also run make check locally and everything checks out

@brson brson merged commit 77c9c08 into rust-lang:beta Jun 28, 2016
@eddyb
Copy link
Member

eddyb commented Jun 28, 2016

For posterity's sake, the reason I said it's okay to remove those changes is that src/librustc_trans/mir/block.rs is actually correct on beta.
Half of the changes in that file from #34141 are reverting a (less correct) fix which didn't get into beta and the other half are for Pair handling, is which is also not in beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants