-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't crash in item_path when an item lacks a name #34561
Conversation
This already landed in master as part of a larger PR, with the motivation of unbreaking logging so I could debug some issue, so I can't really open a new one. This is indeed an unmodified cherry-pick of f6068ea. |
Ok cool, sounds good to me! |
cc @rust-lang/compiler about backporting |
sgtm |
With a lack of r+, the fact that this is already on stable, and the fact that the stable 1.10 release is to be built tomorrow, this is relatively unlikely to be backported at this point. If it's critical to include, however, we can make it work. |
We want to include this - the regression is very annoying when it hits. Could @eddyb r+ this? |
This is indeed a regression to 1.9 (current stable). In that case, I don't think we should backport. |
Ok, removing the beta-nominated tag from this as well. |
Fixes #34027
We may want to use a better name than
<unnamed>
, but I just cherry-picked my old commit.r? @brson