Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: Clean out tmp directory on make clean #34577

Merged
merged 1 commit into from
Jul 1, 2016

Conversation

alexcrichton
Copy link
Member

Right now we generate error index information into this directory, but it's
never cleaned out. This means that if a build bounces because of something in
this directory it'll continue to cause all future builds to fail because the
relevant files are never removed.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

@bors: r+ 98adb2f p=10

Need to un-stick bors

cc @brson though, if you object I can always revert!

bors added a commit that referenced this pull request Jun 30, 2016
rustbuild: Clean out tmp directory on `make clean`

Right now we generate error index information into this directory, but it's
never cleaned out. This means that if a build *bounces* because of something in
this directory it'll continue to cause all future builds to fail because the
relevant files are never removed.
@bors
Copy link
Contributor

bors commented Jun 30, 2016

⌛ Testing commit 98adb2f with merge 78812ca...

@bors
Copy link
Contributor

bors commented Jun 30, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

Right now we generate error index information into this directory, but it's
never cleaned out. This means that if a build *bounces* because of something in
this directory it'll continue to cause all future builds to fail because the
relevant files are never removed.
@alexcrichton
Copy link
Member Author

Ok the fact that both tmp/ and build/tmp/ exists is a bug that we need to fix...

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Jun 30, 2016

📌 Commit 1e48a72 has been approved by brson

@alexcrichton
Copy link
Member Author

@bors: force

@bors
Copy link
Contributor

bors commented Jun 30, 2016

⌛ Testing commit 1e48a72 with merge d15ac78...

@bors
Copy link
Contributor

bors commented Jun 30, 2016

💔 Test failed - auto-linux-cross-opt

@alexcrichton
Copy link
Member Author

@alexcrichton
Copy link
Member Author

@bors: force

@bors
Copy link
Contributor

bors commented Jun 30, 2016

⌛ Testing commit 1e48a72 with merge 2f7b87f...

@bors
Copy link
Contributor

bors commented Jul 1, 2016

💔 Test failed - auto-linux-64-x-android-t

@alexcrichton
Copy link
Member Author

@bors: retry

On Thu, Jun 30, 2016 at 5:18 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-x-android-t
https://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/9616


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34577 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95KyUhW87aJyU3fmXOP63G4ZkMxiPks5qRFy_gaJpZM4JCUYo
.

@bors
Copy link
Contributor

bors commented Jul 1, 2016

⌛ Testing commit 1e48a72 with merge 375fa6e...

bors added a commit that referenced this pull request Jul 1, 2016
rustbuild: Clean out tmp directory on `make clean`

Right now we generate error index information into this directory, but it's
never cleaned out. This means that if a build *bounces* because of something in
this directory it'll continue to cause all future builds to fail because the
relevant files are never removed.
@bors bors merged commit 1e48a72 into rust-lang:master Jul 1, 2016
@alexcrichton alexcrichton deleted the clean-more-yet-again branch July 7, 2016 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants