Skip to content

Doc example improvements for slice::windows. #34988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2016
Merged

Doc example improvements for slice::windows. #34988

merged 1 commit into from
Jul 24, 2016

Conversation

frewsxcv
Copy link
Member

  • Modify existing example to not rely on printing to see results
  • Add an example demonstrating when slice is shorter than size

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 23, 2016

📌 Commit 55fbc3b has been approved by GuillaumeGomez

@frewsxcv
Copy link
Member Author

On my phone right now. I just realized my examples should be slices, not vectors.

@frewsxcv
Copy link
Member Author

Fixed in the latest force push.

@frewsxcv frewsxcv changed the title Doc example improvments for vec::Vec::windows. Doc example improvments for slice::windows. Jul 23, 2016
@frewsxcv
Doc example improvements for slice::windows.
c77f8ce 
* Modify existing example to not rely on printing to see results
* Add an example demonstrating when slice is shorter than `size`
@frewsxcv frewsxcv changed the title Doc example improvments for slice::windows. Doc example improvements for slice::windows. Jul 23, 2016
@GuillaumeGomez
Copy link
Member

Ah right, thanks for the fix!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 23, 2016

📌 Commit c77f8ce has been approved by GuillaumeGomez

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 24, 2016
@Manishearth
Rollup merge of rust-lang#34988 - frewsxcv:vec-windows, r=GuillaumeGomez
89b9ddd 
Doc example improvements for `slice::windows`.

* Modify existing example to not rely on printing to see results
* Add an example demonstrating when slice is shorter than `size`
@Manishearth Manishearth mentioned this pull request Jul 24, 2016
Merged
bors added a commit that referenced this pull request Jul 24, 2016
@bors
Auto merge of #35006 - Manishearth:rollup, r=Manishearth
9316ae5 
Rollup of 7 pull requests

- Successful merges: #34965, #34972, #34975, #34976, #34977, #34988, #34989
- Failed merges:
@bors
Copy link
Collaborator

bors commented Jul 24, 2016

☔ The latest upstream changes (presumably #35006) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit c77f8ce into rust-lang:master Jul 24, 2016
@frewsxcv frewsxcv deleted the vec-windows branch July 24, 2016 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @rust-highfive @GuillaumeGomez @bors @brson