Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no_stack_check (#34915) #35026

Closed
wants to merge 1 commit into from
Closed

Remove no_stack_check (#34915) #35026

wants to merge 1 commit into from

Conversation

abhijeetbhagat
Copy link
Contributor

Part of the fixes for #34915

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aturon
Copy link
Member

aturon commented Jul 25, 2016

r? @nikomatsakis, who is mentoring.

@rust-highfive rust-highfive assigned nikomatsakis and unassigned aturon Jul 25, 2016
@nikomatsakis
Copy link
Contributor

@abhijeetbhagat I think I saw a note that you had many distinct PRs; do you think you can pull them together into one branch? Let me know if you need more help making that happen, git can be a bit rough when getting started. :(

@abhijeetbhagat
Copy link
Contributor Author

@nikomatsakis sure. let me get them into one branch.

@nikomatsakis
Copy link
Contributor

@abhijeetbhagat I'm going to close this PR -- please do re-open if you have something more consolidated (or point me at it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants