-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "x86-64" as the target CPU for NetBSD and Bitrig on amd64. #35033
Conversation
Using "generic" disables a number of features that are present on all x86_64 cpus, the "x86-64" target cpu is the common denominator for that arch. Refs rust-lang#20777
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the PR! I'm curious though, why not do this for all targets? |
"All"? As far as I can tell it's already been done for every other x86_64-based system. The Apple ones use "core2" instead of "x86-64". On NetBSD there's a SSE-related test case failure this fixes because LLVM uses the generic lowest-common-denominator x86 instead of x86_64 which inherently has SSE2. |
I feel like it is a bug in LLVM that |
@bors r=alexcrichton rollup |
📌 Commit 990f193 has been approved by |
…excrichton Use "x86-64" as the target CPU for NetBSD and Bitrig on amd64. Using "generic" disables a number of features that are present on all x86_64 cpus, the "x86-64" target cpu is the common denominator for that arch. Refs rust-lang#20777
Using "generic" disables a number of features that are present on all
x86_64 cpus, the "x86-64" target cpu is the common denominator for that
arch.
Refs #20777