More intuitive explantion of strings formatting #35050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //! | ||
| //! ``` | ||
| //! // Hello {arg 0 (x)} is {arg 1 (0.01) with precision specified inline (5)} | ||
| //! // Hello {arg 0 ("x")} is {arg 1 (0.01) with precision specified inline (5)} |
There was a problem hiding this comment.
why did the quotes get added here?
There was a problem hiding this comment.
In case people mistake it for a variable.
There was a problem hiding this comment.
So then the output on line 437 needs to be updated as well, right?
There was a problem hiding this comment.
er...but the output is Hello x is 0.01000, as written on line 437.
Is it necessary to add extra quotes around the x?
There was a problem hiding this comment.
gah, sorry. I mis-read the diff here; I thought these were inside of format strings. I was just wrong.
|
Thanks! Quick question about the quotes. |
|
@bors: r+ rollup |
|
📌 Commit 14a7f4d has been approved by |
|
Could this be merged now? |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 29, 2016
…abnik More intuitive explantion of strings formatting
bors
added a commit
that referenced
this pull request
Jul 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.