Only export #[no_mangle] extern symbols during LTO #35069
Conversation
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -1542,13 +1541,9 @@ pub fn is_extern_item<'a, 'tcx>(cdata: Cmd, | |||
| let applicable = match item_family(item_doc) { | |||
| ImmStatic | MutStatic => true, | |||
| Fn => { | |||
| let ty::TypeScheme { generics, ty } = get_type(cdata, id, tcx); | |||
| let ty::TypeScheme { generics, ty: _ } = get_type(cdata, id, tcx); | |||
There was a problem hiding this comment.
You should be able to actually change this to:
let ty::TypeScheme { generics, .. } = ...that is, remove the ty matching entirely
There was a problem hiding this comment.
Thank you! I was trying to find that syntax but couldn't.
|
Thanks @wesleywiser! The PR/commit may want to be updated to indicate though that only extern + no_mangle symbols are exported across LTO. I believe today we basically export everything with extern, whether or not it has no_mangle. I'd love to write a test for this as well, but I have no idea how to do so, so seems fine to just have manual verification :) |
|
Also just to confirm, could you gist the contents of the commands in #34985 after this PR? |
wesleywiser
force-pushed
the
too_many_symbols
branch
from
4ffcde5 to
1e46a20
Compare
|
The output of the commands in #34985 is now empty. Did you want the full output of |
|
Nah that's good enough for me! Mind updating the commit message to something like:
|
Previously, all extern symbols were exported even when performing LTO. Now, we only export symbols that are also marked #[no_mangle]. Fixes rust-lang#34985
wesleywiser
force-pushed
the
too_many_symbols
branch
from
1e46a20 to
2dbf00e
Compare
|
How's that? |
alexcrichton
changed the title
extern
|
Looks good to me, thanks @wesleywiser! (also updated the PR title) |
|
Thank you! |
|
⌛ Testing commit 2dbf00e with merge daa25ba... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry On Sat, Jul 30, 2016 at 10:11 AM, bors notifications@github.com wrote:
|
Only export #[no_mangle] extern symbols during LTO Fixes #34985
Fixes #34985