Escape the unmatched surrogates with lower-case hexadecimal numbers #35084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
f? @rust-lang/libs This is a minor breaking change, but similar to other recent |
brson
added
the
relnotes
|
Seems reasonable to me, especially if it brings it in line with other escapes we do |
alexcrichton
added
the
T-libs-api
|
☔ The latest upstream changes (presumably #34485) made this pull request unmergeable. Please resolve the merge conflicts. |
It's done the same way for the rest of the codepoint escapes.
tbu-
force-pushed
the
pr_lowercase_wtf8_debug
branch
from
382c13f to
bb6c27e
Compare
|
@bors r+ |
|
📌 Commit bb6c27e has been approved by |
bors
added a commit
that referenced
this pull request
Aug 2, 2016
Escape the unmatched surrogates with lower-case hexadecimal numbers It's done the same way for the rest of the codepoint escapes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's done the same way for the rest of the codepoint escapes.