Audit C++ types in rustllvm #35174
Merged
Audit C++ types in rustllvm #35174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
arielb1
force-pushed
the
llvm-type-audit
branch
from
1af02df
to
938fb79
Compare
|
@bors r+ |
|
📌 Commit 938fb79 has been approved by |
|
⌛ Testing commit 938fb79 with merge ff34c6b... |
|
💔 Test failed - auto-linux-64-cross-freebsd |
the code has no tests and will just bitrot by itself. this is a [breaking-change]
arielb1
force-pushed
the
llvm-type-audit
branch
from
938fb79
to
3041a97
Compare
|
@bors r=eddyb |
|
📌 Commit 3041a97 has been approved by |
|
⌛ Testing commit 3041a97 with merge a0b4e67... |
This was referenced Aug 3, 2016
Merged
|
Oh nice! Thanks, @arielb1 |
|
I don't understand how you can say that the |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 12, 2020
Added in rust-lang#35174, this was already unused (and new uses have not been introduced since then).
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 12, 2020
Added in rust-lang#35174, this was already unused (and new uses have not been introduced since then).
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 12, 2020
Also introduced in rust-lang#35174, and immediately unused.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 12, 2020
Also unused since introduction in rust-lang#35174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @eddyb
Fixes #35131