-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerate the manpages with the current date. #35438
Conversation
8bf1725
to
72a39e4
Compare
This adds the |
cc @alexcrichton what should we do with rustbuild for this? |
So would you like me to generate the complete correctly timestamped manpage with the |
I just noticed: there is no way to realy reliably calculate the month or year with the rust stdlib, because of TIMEZONES. So I prepared a little vote 😉 : 🎉 So should I implement it with modulo? Pro: Simple; Con: May lead to an inacurate result near the border of a month? I prepared the |
I do not think the accuracy matters much here. It took people a bunch of years to notice the date is out-of-date (…ehem…), and even if month is off-by-one we can always lie a bit and tell build was done early or late. |
@dns2utf8 I'm confused, are you talking about specifically for the rustbuild modifications? You could shell out to |
@dns2utf8 yeah the manpages will need to be generated by dist.rs, if that build system is being used the makefiles aren't even touched. I also agree with @nagisa that accuracy isn't too important here, and @nikomatsakis is also right that either shelling out is fine or pulling a dependency on chrono/time should also be fine. |
Okay, working on it 😄 |
☔ The latest upstream changes (presumably #35414) made this pull request unmergeable. Please resolve the merge conflicts. |
Requires `date` and `cat`
23a6e3f
to
6c2d247
Compare
@dns2utf8 is this ready for review? If not, can we close it and just re-open when it is? |
6c2d247
to
0b8c3ce
Compare
It is still in progress. I will reopen it when it is done. |
Update man pages Until I finish rust-lang#35438
Requires
date
andcat
Follow-up to #35287
r? @nikomatsakis