Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typeck: suggest (x.field)(...) to call struct fields even when x is a reference #35456

Merged
merged 1 commit into from
Aug 8, 2016
Merged

typeck: suggest (x.field)(...) to call struct fields even when x is a reference #35456

merged 1 commit into from
Aug 8, 2016
+74 −20

Conversation

birkenfeld
Copy link
Contributor

Fixes: #33784

Note: This is a reopen of #33785.

@rust-highfive
Copy link
Collaborator

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@birkenfeld
Copy link
Contributor Author

r? @nikomatsakis

@rust-highfive rust-highfive assigned nikomatsakis and unassigned nrc Aug 7, 2016
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 8, 2016

📌 Commit 59af2ac has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Aug 8, 2016

⌛ Testing commit 59af2ac with merge b42a384...

bors added a commit that referenced this pull request Aug 8, 2016
@bors
Auto merge of #35456 - birkenfeld:issue-33784, r=nikomatsakis
b42a384 
typeck: suggest (x.field)(...) to call struct fields even when x is a reference

Fixes: #33784

Note: This is a reopen of #33785.
@bors bors mentioned this pull request Aug 8, 2016
Merged
@bors
Copy link
Contributor

bors commented Aug 8, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: nikomatsakis
Pushing b42a384 to master...

@bors bors merged commit 59af2ac into rust-lang:master Aug 8, 2016
@birkenfeld birkenfeld deleted the issue-33784 branch August 8, 2016 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@birkenfeld @rust-highfive @nikomatsakis @bors @nrc