Kicking off libproc_macro #35538
Kicking off libproc_macro #35538
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -100,6 +100,7 @@ DEPS_test := std getopts term native:rust_test_helpers | |||
|
|
|||
| DEPS_syntax := std term serialize log arena libc rustc_bitflags rustc_unicode rustc_errors syntax_pos | |||
| DEPS_syntax_ext := syntax syntax_pos rustc_errors fmt_macros | |||
| DEPS_proc_macro := syntax syntax_pos rustc_errors fmt_macros rustc_plugin | |||
There was a problem hiding this comment.
deps are inconsistent between here, the Cargo.toml, and the extern crates
I thought we landed your quote macro in libsyntax, which means with this PR there are two copies in the codebase. Can we remove the one from libsyntax? (Or am I misremembering landing it?) |
|
r=me with tests passing and perhaps removing the old quote (if it exists) |
|
You're misremembering. This is the first quote macro. |
cgswords
force-pushed
the
libproc_macro
branch
from
ddde336 to
6bc494b
Compare
|
@cgswords Can you squash? |
cgswords
force-pushed
the
libproc_macro
branch
from
3d04aa1 to
8193188
Compare
|
@eddyb Done! |
|
@cgswords Looking more at it, I think you'll need to start a rustbuild build to update |
cgswords
force-pushed
the
libproc_macro
branch
from
8193188 to
d9d6e8c
Compare
|
@eddyb That should do that. |
|
@bors r=nrc |
|
📌 Commit d9d6e8c has been approved by |
|
⌛ Testing commit d9d6e8c with merge 38002f1... |
cgswords
force-pushed
the
libproc_macro
branch
2 times, most recently
from
7df1036 to
6ef1bbc
Compare
|
Er, accidental re-push. Travis is failing because |
|
@cgswords I would actually expect it to depend on nothing but |
|
@eddyb I can't imagine why |
cgswords
force-pushed
the
libproc_macro
branch
from
6ef1bbc to
8390768
Compare
|
@cgswords My intuition is reversed, having Either way, can you make |
|
@eddyb That won't stop it from throwing the "plugin as library" warning. @alexcrichton how should we shim this? |
|
@cgswords you can add an entry to the whitelist here |
cgswords
force-pushed
the
libproc_macro
branch
from
8390768 to
98c8e0a
Compare
|
Whitelist entry added. |
|
@bors r=nrc |
|
📌 Commit 98c8e0a has been approved by |
Kicking off libproc_macro This PR introduces `libproc_macro`, which is currently quite bare-bones (just a few macro construction tools and an initial `quote!` macro). This PR also introduces a few test cases for it, and an additional `shim` file (at `src/libsyntax/ext/proc_macro_shim.rs` to allow a facsimile usage of Macros 2.0 *today*!
|
🤘 |
This PR introduces
libproc_macro, which is currently quite bare-bones (just a few macro construction tools and an initialquote!macro).This PR also introduces a few test cases for it, and an additional
shimfile (atsrc/libsyntax/ext/proc_macro_shim.rsto allow a facsimile usage of Macros 2.0 today!