Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0370 to new error code format. #35659

Closed
wants to merge 0 commits into from
Closed

Update E0370 to new error code format. #35659

wants to merge 0 commits into from

Conversation

terrynsun
Copy link
Contributor

Fixes #35634 as part of #35233.

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

Thanks for the PR!

Looks like you'll need to run the check and update some of the other unit tests. Since you added a label, it's now showing up in those tests.

---- [compile-fail] compile-fail/discrim-overflow-2.rs stdout ----

error: /build/src/test/compile-fail/discrim-overflow-2.rs:27: unexpected "error": '27:9: 27:13: enum overflowed [E0370]'
error: /build/src/test/compile-fail/discrim-overflow-2.rs:36: unexpected "error": '36:9: 36:13: enum overflowed [E0370]'
error: /build/src/test/compile-fail/discrim-overflow-2.rs:45: unexpected "error": '45:9: 45:13: enum overflowed [E0370]'
error: /build/src/test/compile-fail/discrim-overflow-2.rs:54: unexpected "error": '54:9: 54:13: enum overflowed [E0370]'
error: /build/src/test/compile-fail/discrim-overflow-2.rs:63: unexpected "error": '63:9: 63:13: enum overflowed [E0370]'
error: /build/src/test/compile-fail/discrim-overflow-2.rs:72: unexpected "error": '72:9: 72:13: enum overflowed [E0370]'
error: /build/src/test/compile-fail/discrim-overflow-2.rs:81: unexpected "error": '81:9: 81:13: enum overflowed [E0370]'
error: /build/src/test/compile-fail/discrim-overflow-2.rs:90: unexpected "error": '90:9: 90:13: enum overflowed [E0370]'

You can check this out by running the check and updating the unit tests that fail:

python src/bootstrap/bootstrap.py --step check-cfail --stage 1

@terrynsun
Copy link
Contributor Author

Thanks! I was having trouble finding the error in the output.

@terrynsun terrynsun closed this Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants