Fixes issue #11004 #35749
Merged
Fixes issue #11004 #35749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. @bors r+ rollup |
|
📌 Commit 356615b has been approved by |
| #[cfg(not(works))] | ||
| unsafe fn access(n:*mut A) -> (i32, f64) { | ||
| let x : i32 = n.x; //~ ERROR attempted access of field `x` | ||
| //~| NOTE `A` is a native pointer; perhaps you need to deref with `(*A).x` |
There was a problem hiding this comment.
Surely A isn't the native pointer, n is. Also (*A).x isn't a valid expression. I think this should be either "n is a native pointer; perhaps you need to deref with (*n).x" or "*mut A is a native pointer; perhaps you need to deref with (*n).x".
There was a problem hiding this comment.
@ollie27 - good catch. This is what I get for reviewing with a sleepy brain
|
@bors r- I missed that the wrong message was given. |
GuillaumeGomez
force-pushed
the
raw_field
branch
from
356615b to
feeed0b
Compare
|
Updated. |
|
@bors r+ rollup |
|
📌 Commit feeed0b has been approved by |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Aug 18, 2016
…ndturner Fixes issue rust-lang#11004 Fixes rust-lang#11004. r? @jonathandturner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11004.
r? @jonathandturner