Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement std::convert traits for char #35755

Merged
merged 2 commits into from
Sep 1, 2016
Merged

Implement std::convert traits for char #35755

merged 2 commits into from
Sep 1, 2016

Commits on Aug 29, 2016

  1. Implement From<char> for u32, and From<u8> for char 

    These fit with other From implementations between integer types.

This helps the coding style of avoiding the 'as' operator that sometimes
silently truncates, and signals that these specific conversions are
lossless and infaillible.
    @SimonSapin
    SimonSapin committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    41d0a89 View commit details
    Browse the repository at this point in the history

  2. Implement TryFrom<u32> for char 

    For symmetry with From<char> for u32.
    @SimonSapin
    SimonSapin committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    f040208 View commit details
    Browse the repository at this point in the history