Wording fixes in error messages #35839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -29,7 +29,7 @@ use rustc::hir; | |||
| pub fn check_legal_trait_for_method_call(ccx: &CrateCtxt, span: Span, trait_id: DefId) { | |||
| if ccx.tcx.lang_items.drop_trait() == Some(trait_id) { | |||
| struct_span_err!(ccx.tcx.sess, span, E0040, "explicit use of destructor method") | |||
| .span_label(span, &format!("call to destructor method")) | |||
| .span_label(span, &format!("explicit destructor calls not allowed")) | |||
There was a problem hiding this comment.
Not sure about this one, other labels seem to be elaborating on the original error message, whereas this one is just rephrasing it.
There was a problem hiding this comment.
That's true sometimes. We don't yet have the rules set in stone, rather more of a best effort.
With some errors, like this one, we use a rephrasing. Mostly this is because we're not sure where people will look first: the title or the label.
|
@bors r+ retry |
|
📌 Commit 54d0acd has been approved by |
|
@bors rollup |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 20, 2016
Wording fixes in error messages This PR is largely wording fixes to existing PRs that I found going back through the ones that have already been updated. Sometimes seeing the message in context made me think "oh there's a better wording!" There's one additional fix. This will also prevent the secondary underlining of derive call (since they look like macros to the system in the way I was using): ``` error[E0184]: the trait `Copy` may not be implemented for this type; the type has a destructor --> src/test/compile-fail/E0184.rs:11:10 | 11 | #[derive(Copy)] //~ ERROR E0184 | ^^^^ | | | in this macro invocation ``` Is now just: ``` error[E0184]: the trait `Copy` may not be implemented for this type; the type has a destructor --> src/test/compile-fail/E0184.rs:11:10 | 11 | #[derive(Copy)] //~ ERROR E0184 | ^^^^ ```
bors
added a commit
that referenced
this pull request
Aug 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is largely wording fixes to existing PRs that I found going back through the ones that have already been updated. Sometimes seeing the message in context made me think "oh there's a better wording!"
There's one additional fix. This will also prevent the secondary underlining of derive call (since they look like macros to the system in the way I was using):
Is now just: