-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace Mul
example with something more evocative of multiplication
#35860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Squash please! :p |
I may have gone a bit overboard on this one. Numbers are fun. tone down the error message
matthew-piziak
force-pushed
the
mul-example
branch
from
August 22, 2016 20:50
cd00145
to
38f0bca
Compare
Done! |
@bors: r+ rollup |
📌 Commit 38f0bca has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 22, 2016
…aumeGomez replace `Mul` example with something more evocative of multiplication I may have gone a bit overboard on this one. Numbers are fun.
matthew-piziak
added a commit
to matthew-piziak/rust
that referenced
this pull request
Aug 23, 2016
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Aug 23, 2016
…, r=GuillaumeGomez replace `Div` example with something more evocative of division Analogous to PR rust-lang#35860. r? @GuillaumeGomez
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Aug 23, 2016
…, r=GuillaumeGomez replace `Div` example with something more evocative of division Analogous to PR rust-lang#35860. r? @GuillaumeGomez
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 23, 2016
…, r=GuillaumeGomez replace `Div` example with something more evocative of division Analogous to PR rust-lang#35860. r? @GuillaumeGomez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may have gone a bit overboard on this one. Numbers are fun.