Skip to content

Use #[prelude_import] in libcore and libstd #35906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2016
Merged

Use #[prelude_import] in libcore and libstd #35906

merged 3 commits into from
Aug 26, 2016

Conversation

@jseyfried
Copy link
Contributor

r? @eddyb

@jseyfried
Copy link
Contributor Author

c.f. #34108
cc @petrochenkov

@eddyb
Copy link
Member

eddyb commented Aug 22, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 22, 2016

📌 Commit 2b0ea00 has been approved by eddyb

@petrochenkov
Copy link
Contributor

Nice!

@bors
Copy link
Collaborator

bors commented Aug 23, 2016

☔ The latest upstream changes (presumably #35766) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried
Copy link
Contributor Author

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented Aug 25, 2016

📌 Commit a9a2979 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Aug 26, 2016

⌛ Testing commit a9a2979 with merge eaf71f8...

bors added a commit that referenced this pull request Aug 26, 2016
@bors
Auto merge of #35906 - jseyfried:local_prelude, r=eddyb
eaf71f8 
Use `#[prelude_import]` in `libcore` and `libstd`

r? @eddyb
@bors
Copy link
Collaborator

bors commented Aug 26, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@jseyfried
Copy link
Contributor Author

@bors retry

@bors
Copy link
Collaborator

bors commented Aug 26, 2016

⚡ Previous build results for auto-linux-cross-opt, auto-win-msvc-64-cargotest are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild...

@bors
Copy link
Collaborator

bors commented Aug 26, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing eaf71f8 to master...

@bors bors merged commit a9a2979 into rust-lang:master Aug 26, 2016
This was referenced Aug 26, 2016
Closed
Merged
Closed
@jseyfried jseyfried deleted the local_prelude branch October 16, 2016 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddyb eddyb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jseyfried @eddyb @bors @petrochenkov