Skip to content

Use question_mark feature in libsyntax. #36037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use question_mark feature in libsyntax. #36037

wants to merge 1 commit into from

Conversation

ahmedcharles
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@japaric
Copy link
Member

japaric commented Aug 27, 2016

I think we explicitly don't use ? in the syntax crate because it makes hard to update the syntex crate.

@ahmedcharles
Copy link
Contributor Author

ahmedcharles commented Aug 27, 2016

Really? How does it make it hard? I guess I can't submit the same change there since it's purpose is to work on stable. :)

It will be stable in a few weeks, anyways, right?

@japaric
Copy link
Member

japaric commented Aug 27, 2016

Really? How does it make it hard? I guess I can't submit the same change there since it's purpose is to work on stable.

The fact that doesn't work on stable means that syntex maintainers have to revert the ?s back to trys when porting the syntax crate to the stable channel. See #34311

It's better to ask @erickt directly.

It will be stable in a few weeks, anyways, right?

It just entered FCP. AIUI, it's at least one cycle to decide whether it will enter the next beta, then another cycle for it to go from beta to stable. So two releases at least; that's around 3 months.

@ahmedcharles
Copy link
Contributor Author

Yeah, I understood why as I typed the comment. Anyways, it's already done and I'll keep it rebased on master. :)

@nrc nrc mentioned this pull request Aug 28, 2016
@nrc
Copy link
Member

nrc commented Aug 28, 2016

Yeah, for the sake of @erickt's sanity, we shouldn't land this until ? is stabilised. Closing this PR for now, but please do re-open once ? is stable.

@nrc nrc closed this Aug 28, 2016
@ahmedcharles
Copy link
Contributor Author

Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants