-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #36049
Merged
Merged
Rollup of 6 pull requests #36049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sophiajt
commented
Aug 27, 2016
- Successful merges: Update E0389 to the new format. #35630 #35657, Make E0094 underline better #35980, Update E0277 to new error format #35985, Update E0453 to new error format #35989, Err codes #36003, update error E0450 to new format #36044
- Failed merges:
Fixes rust-lang#35966. Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Fixes rust-lang#35311. Part of rust-lang#35233. r? @jonathandturner
Fixes rust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
Update E0389 to the new format. rust-lang#35630
…turner Make E0094 underline better r? @jonathandturner
…thandturner Update E0277 to new error format Fixes rust-lang#35311. Part of rust-lang#35233. r? @jonathandturner
…thandturner Update E0453 to new error format Fixes rust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
…ndturner Err codes r? @jonathandturner
update error E0450 to new format Fixes rust-lang#35925 as part of rust-lang#35233. I've solve the bonus, and I wonder if any simpler way to do this. But may be possible simplify if let expressions? r? @jonathandturner
@bors r+ p=1 |
📌 Commit d00a89a has been approved by |
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
💔 Test failed - auto-mac-32-opt |
@bors retry |
This was referenced Aug 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.