Document try!'s error conversion behaviour #36099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
src/libcore/macros.rs
Outdated
src/libcore/macros.rs
Outdated
There was a problem hiding this comment.
"unwrap" is an unfortunate choice of words here, since unwrap() is a method, and it doesn't use it
skade
force-pushed
the
better-try-documentation
branch
from
ac71520 to
33ba3df
Compare
|
Fixed all comments. |
skade
force-pushed
the
better-try-documentation
branch
from
33ba3df to
dea3179
Compare
skade
force-pushed
the
better-try-documentation
branch
from
dea3179 to
0f8eb81
Compare
|
@steveklabnik updated. Made it more concise (hopefully) and direct. |
|
I'm into it. Build failure looks spurious. Thanks! @bors: r+ rollup |
|
📌 Commit 0f8eb81 has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 2, 2016
…teveklabnik Document try!'s error conversion behaviour try!'s documentation currently doesn't document the error conversion behaviour of the macro. This patch extends the documentation. Open questions: * is it worthwhile to have seperate examples with and without wrapping behaviour? It's not immediately obvious that From<T> for T is always defined. Though this is necessary for the macro to work in any case, is this the place to expect that knowledge.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 2, 2016
…teveklabnik Document try!'s error conversion behaviour try!'s documentation currently doesn't document the error conversion behaviour of the macro. This patch extends the documentation. Open questions: * is it worthwhile to have seperate examples with and without wrapping behaviour? It's not immediately obvious that From<T> for T is always defined. Though this is necessary for the macro to work in any case, is this the place to expect that knowledge.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 2, 2016
…teveklabnik Document try!'s error conversion behaviour try!'s documentation currently doesn't document the error conversion behaviour of the macro. This patch extends the documentation. Open questions: * is it worthwhile to have seperate examples with and without wrapping behaviour? It's not immediately obvious that From<T> for T is always defined. Though this is necessary for the macro to work in any case, is this the place to expect that knowledge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try!'s documentation currently doesn't document the error conversion behaviour of the macro. This patch extends the documentation.
Open questions: