Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #36274

Merged
merged 10 commits into from
Sep 6, 2016
Merged

Rollup of 6 pull requests #36274

merged 10 commits into from
Sep 6, 2016

Conversation

acrrd and others added 5 commits September 2, 2016 22:28
…--enable-local-rebuild

When using --enable-local-rebuild configure options, the configure
script will test rustc version. But when running it, it will not use the
libraries in the local-rust-root directory.

So use `LD_LIBRARY_PATH` environment variable to correct it.
This feature was accidentally removed in
rust-lang#35957.
@Manishearth
Copy link
Member Author

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Sep 5, 2016

📌 Commit 214313a has been approved by Manishearth

@rust-highfive
Copy link
Collaborator

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Sep 5, 2016

⌛ Testing commit 214313a with merge b682d7b...

@bors
Copy link
Contributor

bors commented Sep 5, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@Manishearth
Copy link
Member Author

@bors-servo retry force

…umeGomez

Indicate where `core::result::IntoIter` is created.

None
Use libraries from local-rust-root directory in configure when using …

…--enable-local-rebuild

When using --enable-local-rebuild configure options, the configure
script will test rustc version. But when running it, it will not use the
libraries in the local-rust-root directory.

So use `LD_LIBRARY_PATH` environment variable to correct it.

Under OpenBSD, we use `--enable-local-rebuild` for rebuilding rustc-1.11.0 using rustc-1.11.0. But as it is in use in -current (the developpment branch of OpenBSD), system libraries could easily have ABI/API changes. The (unofficial) bootstrap (rustc-1.11.0 used for building rustc-1.11.0) include several system libraries to permit it to run. The build system use libraries in stage0/lib directory. But the configure script doesn't.

Due to my special use of `--enable-local-rebuild`, I dunno if this PR is suitable for inclusion. But it corrects a difference between build and configure use of the binary.

r? @alexcrichton
…rielb1

Add back feature accidentally removed

This feature was accidentally removed in
rust-lang#35957.
@frewsxcv
Copy link
Member

frewsxcv commented Sep 5, 2016

FYI, I don't think bors sees this PR.

@TimNN
Copy link
Contributor

TimNN commented Sep 5, 2016

I think this needs an r+ since new / updated commits were pushed.

@Manishearth
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Sep 5, 2016

📌 Commit 20ec61e has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Sep 6, 2016

⌛ Testing commit 20ec61e with merge e1d0de8...

bors added a commit that referenced this pull request Sep 6, 2016
Rollup of 6 pull requests

- Successful merges: #35845, #35983, #36065, #36102, #36242, #36245
- Failed merges:
@bors bors merged commit 20ec61e into rust-lang:master Sep 6, 2016
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.