Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0297 to new error format #36389

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Update E0297 to new error format #36389

merged 1 commit into from
Sep 13, 2016

Conversation

jfirebaugh
Copy link
Contributor

Fixes #35521.
Part of #35233.

I didn't attempt the bonus of narrowing the span to focus on the "for <pattern>" piece (it's my first time contributing), but I'm happy to do so given some hints.

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Sep 10, 2016

📌 Commit f647db4 has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Sep 11, 2016

⌛ Testing commit f647db4 with merge 1e0dbbe...

bors added a commit that referenced this pull request Sep 11, 2016
Update E0297 to new error format

Fixes #35521.
Part of #35233.

I didn't attempt the bonus of narrowing the span to focus on the "for `<pattern>`" piece (it's my first time contributing), but I'm happy to do so given some hints.

r? @jonathandturner
@bors
Copy link
Contributor

bors commented Sep 11, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Sat, Sep 10, 2016 at 6:07 PM, bors notifications@github.com wrote:

💔 Test failed - auto-mac-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-mac-64-opt-rustbuild/builds/2434


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36389 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95GOiZAPJwhTIBo2OY5hEV120QhE_ks5qo1Q1gaJpZM4J50dT
.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 13, 2016
Update E0297 to new error format

Fixes rust-lang#35521.
Part of rust-lang#35233.

I didn't attempt the bonus of narrowing the span to focus on the "for `<pattern>`" piece (it's my first time contributing), but I'm happy to do so given some hints.

r? @jonathandturner
bors added a commit that referenced this pull request Sep 13, 2016
Rollup of 5 pull requests

- Successful merges: #36357, #36380, #36389, #36397, #36402
- Failed merges:
@bors bors merged commit f647db4 into rust-lang:master Sep 13, 2016
@jfirebaugh jfirebaugh deleted the E0297 branch September 13, 2016 15:56
@jfirebaugh
Copy link
Contributor Author

@GuillaumeGomez Can I get write access to the issue tracker? I'd like to do some gardening, closing out all the "EXXXX needs to be updated to new format" issues that have in fact been already fixed. There seem to be quite a few, and it's cluttering up the E-Easy label for folks looking for something to contribute.

@GuillaumeGomez
Copy link
Member

I'm not the one you should ask, ask @steveklabnik.

@sophiajt
Copy link
Contributor

@jfirebaugh - my bad. I've gone through and closed the ones that are already finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants