-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E0297 to new error format #36389
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks! @bors: r+ rollup |
📌 Commit f647db4 has been approved by |
Update E0297 to new error format Fixes #35521. Part of #35233. I didn't attempt the bonus of narrowing the span to focus on the "for `<pattern>`" piece (it's my first time contributing), but I'm happy to do so given some hints. r? @jonathandturner
💔 Test failed - auto-mac-64-opt-rustbuild |
@bors: retry On Sat, Sep 10, 2016 at 6:07 PM, bors notifications@github.com wrote:
|
Update E0297 to new error format Fixes rust-lang#35521. Part of rust-lang#35233. I didn't attempt the bonus of narrowing the span to focus on the "for `<pattern>`" piece (it's my first time contributing), but I'm happy to do so given some hints. r? @jonathandturner
@GuillaumeGomez Can I get write access to the issue tracker? I'd like to do some gardening, closing out all the "EXXXX needs to be updated to new format" issues that have in fact been already fixed. There seem to be quite a few, and it's cluttering up the |
I'm not the one you should ask, ask @steveklabnik. |
@jfirebaugh - my bad. I've gone through and closed the ones that are already finished. |
Fixes #35521.
Part of #35233.
I didn't attempt the bonus of narrowing the span to focus on the "for
<pattern>
" piece (it's my first time contributing), but I'm happy to do so given some hints.r? @jonathandturner