Skip to content

rustbuild: Nicer error for host builds of targets #36442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2016

Conversation

alexcrichton
Copy link
Member

If a triple is configured only as a target, not a host, then trying to build
that triple with host artifacts would cause a panic. Fail a little nicer
instead.

Closes #36268

If a triple is configured only as a target, not a host, then trying to build
that triple with host artifacts would cause a panic. Fail a little nicer
instead.

Closes rust-lang#36268
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Sep 20, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 20, 2016

📌 Commit 6d78620 has been approved by brson

@bors
Copy link
Collaborator

bors commented Sep 20, 2016

⌛ Testing commit 6d78620 with merge f6b6647...

bors added a commit that referenced this pull request Sep 20, 2016
rustbuild: Nicer error for host builds of targets

If a triple is configured only as a target, not a host, then trying to build
that triple with host artifacts would cause a panic. Fail a little nicer
instead.

Closes #36268
@bors
Copy link
Collaborator

bors commented Sep 20, 2016

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton
Copy link
Member Author

@bors: retry

On Tue, Sep 20, 2016 at 1:24 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/5693


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#36442 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95NgBlWzDumMk9xjI1NsR_-GkJm19ks5qr5hXgaJpZM4J7UHD
.

@bors
Copy link
Collaborator

bors commented Sep 25, 2016

⌛ Testing commit 6d78620 with merge 95abee1...

bors added a commit that referenced this pull request Sep 25, 2016
rustbuild: Nicer error for host builds of targets

If a triple is configured only as a target, not a host, then trying to build
that triple with host artifacts would cause a panic. Fail a little nicer
instead.

Closes #36268
@bors bors merged commit 6d78620 into rust-lang:master Sep 26, 2016
@alexcrichton alexcrichton deleted the rustbuild-cross branch October 6, 2016 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants