Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated Doc Comment on BufReader::seek #36632

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Sep 21, 2016

A long time ago non-panicking unwrap methods were renamed to into_inner in this Pull Request: #19149

Looks like this doc comment was not updated however.

A long time ago non-panicking `unwrap` methods were renamed to `into_inner` in this Pull Request: rust-lang#19149

Looks like this doc comment was not updated however.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sfackler
Copy link
Member

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Sep 22, 2016

📌 Commit e107c8b has been approved by sfackler

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 22, 2016
Fix outdated Doc Comment on BufReader::seek

A long time ago non-panicking `unwrap` methods were renamed to `into_inner` in this Pull Request: rust-lang#19149

Looks like this doc comment was not updated however.
bors added a commit that referenced this pull request Sep 22, 2016
Rollup of 7 pull requests

- Successful merges: #36330, #36423, #36539, #36571, #36589, #36600, #36632
- Failed merges:
@bors bors merged commit e107c8b into rust-lang:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants