Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE on some macros in const integer positions (e.g. [u8; m!()]) #36819

Merged
merged 2 commits into from
Sep 30, 2016
Merged

Fix ICE on some macros in const integer positions (e.g. [u8; m!()]) #36819

merged 2 commits into from
Sep 30, 2016

Conversation

jseyfried
Copy link
Contributor

@jseyfried jseyfried commented Sep 29, 2016 •
edited
Loading

Fixes #36816 (EDIT: and fixes #36834).
r? @nrc

@jseyfried jseyfried mentioned this pull request Sep 29, 2016
Closed
@nrc
Copy link
Member

nrc commented Sep 29, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 29, 2016

📌 Commit 4bec961 has been approved by nrc

@bors
Copy link
Contributor

bors commented Sep 30, 2016

⌛ Testing commit 4bec961 with merge c88ed2a...

bors added a commit that referenced this pull request Sep 30, 2016
@bors
Auto merge of #36819 - jseyfried:fix_ast_const_integer_ice, r=nrc
c88ed2a 
Fix ICE on some macros in const integer positions (e.g. `[u8; m!()]`)

Fixes #36816.
r? @nrc
@bors
Copy link
Contributor

bors commented Sep 30, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing c88ed2a to master...

@bors bors merged commit 4bec961 into rust-lang:master Sep 30, 2016
@tormol tormol mentioned this pull request Sep 30, 2016
Merged
@pmarcelll pmarcelll mentioned this pull request Oct 1, 2016
Closed
@TimNN TimNN mentioned this pull request Oct 1, 2016
Closed
@jseyfried jseyfried deleted the fix_ast_const_integer_ice branch October 2, 2016 03:35
@jseyfried
Copy link
Contributor Author

This also fixes #36834.

@jonas-schievink jonas-schievink mentioned this pull request Oct 2, 2016
Closed
@tormol tormol mentioned this pull request Oct 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE compiling cargo-graph v0.3.0 with today's nightly objc v0.2.1 causes compiler panic on nightly (OSX)
3 participants
@jseyfried @nrc @bors