loosen assertion against proj in collector #36876
Conversation
| assert!(concrete_substs.is_normalized_for_trans()); | ||
| //assert!(concrete_substs.is_normalized_for_trans(), | ||
| // "concrete_substs not normalized for trans: {:?}", | ||
| // concrete_substs); |
There was a problem hiding this comment.
Why only comment this out?
There was a problem hiding this comment.
you mean versus remove it entirely?
There was a problem hiding this comment.
Still, I have to admit: @nikomatsakis it does not seem like you are ever actually reading the newly added HAS_NORMALIZABLE_PROJECTION bit; you are merely setting it...? Did you intend to incorporate that bit into this assertion, and then you changed your mind and decided to just remove the assertion entirely?
There was a problem hiding this comment.
Yes, this doesn't "loosen" the assertion, it disables it. Looks like the change to the assertion is incomplete or something.
There was a problem hiding this comment.
Er, I didn't mean to commit that part.
nikomatsakis
force-pushed
the
issue-36381
branch
from
40800aa
to
5ea4ebb
Compare
|
@nikomatsakis r=me once you address the travis failure. |
The collector was asserting a total absence of projections, but some projections are expected, even in trans: in particular, projections containing higher-ranked regions, which we don't currently normalize.
nikomatsakis
force-pushed
the
issue-36381
branch
from
5ea4ebb
to
58b75f7
Compare
|
@bors r=pnkfelix |
|
📌 Commit 58b75f7 has been approved by |
|
@pnkfelix do you think we ought to beta backport, actually? This is a stable-to-stable regression, I guess. |
pnkfelix
added
the
beta-nominated
nikomatsakis
added
the
beta-accepted
|
Accepting for backport because tiny patch, fixes regression. cc @rust-lang/compiler |
brson
removed
the
beta-nominated
The collector was asserting a total absence of projections, but some projections are expected, even in trans: in particular, projections containing higher-ranked regions, which we don't currently normalize.
r? @pnkfelix
Fixes #36381