Store a pointer to llvm::Archive::Child rather than by value #36896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Recent changes to LLVM cause the constructor to Archive::Child to have the same signature, but require a parent archive (otherwise a segfault is hit). This is backwards compatible with the current LLVM. This will need to be done before the next LLVM upgrade.
dylanmckay
force-pushed
the
pointerize-archive-child
branch
from
15e1cfe to
bba47b3
Compare
shepmaster
reviewed
Oct 2, 2016
| @@ -191,7 +185,7 @@ LLVMRustArchiveMemberNew(char *Filename, char *Name, | |||
| Member->filename = Filename; | |||
| Member->name = Name; | |||
| if (child) | |||
There was a problem hiding this comment.
This conditional could probably be removed.
|
Looks like this may segfault on LLVM 3.7 as well? (travis) |
|
This has been fixed in upstream LLVM commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to LLVM cause the constructor to
Archive::Childto havethe same signature, but require a parent archive (otherwise a segfault
is hit).
This is backwards compatible with the current LLVM.
This will need to be done before the next LLVM upgrade.