Fix documentation for `write!` on `std::fmt` page #36937

wesleywiser · 2016-10-03T18:23:19Z

GuillaumeGomez · 2016-10-03T19:44:24Z

src/libcollections/fmt.rs

While you're at it. Can you add urls for write_fmt and std::io::Write please?

Sure! Can you check the urls? I'm not sure I added them correctly

Travis will tell us.

frewsxcv · 2016-10-03T20:24:20Z

tidy check stage0 (x86_64-unknown-linux-gnu)
/build/src/libcollections/fmt.rs:264: trailing whitespace

wesleywiser · 2016-10-03T20:27:09Z

Fixed, thanks!

wesleywiser · 2016-10-04T15:41:59Z

src/libcollections/fmt.rs

It looks like the paths are wrong. I've tried ../io/trait.Write.html and ../../io/trait.Write.html but neither seem to work. @GuillaumeGomez any ideas?

The better thing to test is to build docs and then check by hand:

make docs

Then open doc/index.html with any web browser, go to the modified url and click on it. Then just compare with "real" url and you'll figure out easily.

Thanks for the tip! When I try that, the links work correctly on my local computer but they still fail on Travis. Should I just remove them for now?

Yes, I'll take care of them. Once removed, please squash your commits.

Done. Thank you!

Fixes rust-lang#36906

GuillaumeGomez · 2016-10-07T21:58:59Z

@bors: r=frewsxcv rollup

bors · 2016-10-07T21:59:08Z

📌 Commit bbd0040 has been approved by frewsxcv

Fix documentation for `write!` on `std::fmt` page Fixes rust-lang#36906

Rollup of 6 pull requests - Successful merges: #36937, #37016, #37028, #37029, #37031, #37034 - Failed merges: #37027

GuillaumeGomez reviewed Oct 3, 2016

View reviewed changes

wesleywiser force-pushed the patch-3 branch from 2ba57b9 to 418b72b Compare October 4, 2016 01:56

wesleywiser commented Oct 4, 2016

View reviewed changes

wesleywiser force-pushed the patch-3 branch 2 times, most recently from 2407070 to 3694a4f Compare October 6, 2016 01:26

Fix documentation for write! on std::fmt page

bbd0040

Fixes rust-lang#36906

wesleywiser force-pushed the patch-3 branch from 3694a4f to bbd0040 Compare October 7, 2016 13:54

Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 8, 2016

Rollup merge of rust-lang#36937 - wesleywiser:patch-3, r=frewsxcv

1d20468

Fix documentation for `write!` on `std::fmt` page Fixes rust-lang#36906

Manishearth mentioned this pull request Oct 8, 2016

Rollup of 6 pull requests #37039

Merged

bors added a commit that referenced this pull request Oct 8, 2016

Auto merge of #37039 - Manishearth:rollup, r=Manishearth

4344f14

Rollup of 6 pull requests - Successful merges: #36937, #37016, #37028, #37029, #37031, #37034 - Failed merges: #37027

bors merged commit bbd0040 into rust-lang:master Oct 8, 2016

wesleywiser deleted the patch-3 branch October 8, 2016 17:13

Fix documentation for write! on std::fmt page #36937

Fix documentation for write! on std::fmt page #36937

Uh oh!

Conversation

wesleywiser commented Oct 3, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

frewsxcv commented Oct 3, 2016

Uh oh!

wesleywiser commented Oct 3, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Oct 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Oct 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix documentation for `write!` on `std::fmt` page #36937

Fix documentation for `write!` on `std::fmt` page #36937

GuillaumeGomez commented Oct 7, 2016 •

edited

Loading