tidy/features: fix checking of lang features #37196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollie27
reviewed
Oct 15, 2016
| @@ -286,7 +286,6 @@ pub mod builtin { | |||
| /// // fn concat_idents!(new, fun, name) { } // not usable in this way! | |||
| /// # } | |||
| /// ``` | |||
| #[unstable(feature = "concat_idents", issue = "29599")] | |||
There was a problem hiding this comment.
This was added in #34404 so the macro is marked unstable in the docs. If the feature name is conflicting then it should just be renamed here.
tamird
force-pushed
the
fix-tidy-features
branch
from
59e9f57 to
5f1aa61
Compare
|
@brson ping? |
|
@tamird Hi! Sorry for not seeing this earlier. This looks great. Do you mind adding an assert that some lang features are found, so that this doesn't regress again in the future? |
`git ls-files` now exits zero when called with a missing file; check that the file is included in the output before reporting a checked-in binary. Observed with git 2.10.1 and tripped by a symlink created by tests: src/test/run-make/issue-26006/out/time/deps/liblibc.rlib -> out/libc/liblibc.rlib
Removes the `STATUSES` static which duplicates truth from the pattern
match in `collect_lang_features`.
Fixes existing duplicates by renaming:
- never_type{,_impls} on `impl`s on `!`
- concat_idents{,_macro} on `macro_rules! concat_idents`
Fixes rust-lang#37013.
tamird
force-pushed
the
fix-tidy-features
branch
from
5f1aa61 to
bef1911
Compare
|
Yep! Done. |
|
@bors r+ |
|
📌 Commit bef1911 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 28, 2016
tidy/features: fix checking of lang features r? @brson See the commit messages - the actual "fixes" here are strawmen; I'm happy to adjust them if you have suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brson
See the commit messages - the actual "fixes" here are strawmen; I'm happy to adjust them if you have suggestions.