-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run rustfmt on librustc_driver folder #37296
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@nikomatsakis LGTM. What do you think? |
@bors r+ rollup |
☔ The latest upstream changes (presumably #37301) made this pull request unmergeable. Please resolve the merge conflicts. |
}), sess) | ||
f(&annotation, payload, ast_map.forest.krate()) | ||
}), | ||
sess) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this formatting confusing and hard to read.
@@ -354,7 +353,8 @@ impl<'ast> pprust::PpAnn for IdentifiedAnnotation<'ast> { | |||
} | |||
fn post(&self, s: &mut pprust::State, node: pprust::AnnNode) -> io::Result<()> { | |||
match node { | |||
pprust::NodeIdent(_) | pprust::NodeName(_) => Ok(()), | |||
pprust::NodeIdent(_) | | |||
pprust::NodeName(_) => Ok(()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needless added line break.
node: ast::StmtKind::Expr(e), | ||
}).into_iter().collect(), | ||
stmts: e.map(|e| { | ||
ast::Stmt { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange indent.
annotation.pp_ann(), | ||
false) | ||
}).unwrap() | ||
debug!("pretty printing source code {:?}", s); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange indent.
true) | ||
}) | ||
} | ||
(PpmSource(s), _) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect indent (looks like a rustfmt
bug).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}), sess).unwrap(); | ||
}), | ||
sess) | ||
.unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very strange/confusing.
@nikomatsakis rollup pls |
I filed an issue for the over-indented match arm. I think all the other issues are already known. |
☔ The latest upstream changes (presumably #37400) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors r+ rollup |
📌 Commit f32ce9c has been approved by |
…komatsakis run rustfmt on librustc_driver folder
No description provided.