Add missing urls in collections module #37304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: delegate=frewsxcv |
|
✌️ @frewsxcv can now approve this pull request |
frewsxcv
approved these changes
Oct 24, 2016
| //! done, the vacant entry is consumed and converted into a mutable reference to | ||
| //! the value that was inserted. This allows for further manipulation of the | ||
| //! value beyond the lifetime of the search itself. This is useful if complex | ||
| //! logic needs to be performed on the value regardless of whether the value was | ||
| //! just inserted. | ||
| //! | ||
| //! If an `Occupied(entry)` is yielded, then the key *was* found. In this case, | ||
| //! the user has several options: they can `get`, `insert`, or `remove` the |
There was a problem hiding this comment.
I'm generally in favor of the serial comma, but I'm not sure if Rust has an official policy around this. Regardless, in this particular instance, I don't think there's any ambiguity in either scenario so I won't waste your time changing it.
There was a problem hiding this comment.
Same here, generally very pro, unsure if we've made it actual policy.
There was a problem hiding this comment.
As said on IRC: I'm in favor for more fluidity. Commas break readings and shouldn't be more present than necessary.
|
Looks great, thanks! ✨ @bors r+ rollup |
|
📌 Commit 9ec7c65 has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Oct 24, 2016
…rewsxcv Add missing urls in collections module r? @steveklabnik
bors
added a commit
that referenced
this pull request
Oct 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @steveklabnik