run rustfmt on librustc_metadata folder #37350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
reviewed
Oct 22, 2016
| // crate will import them from their original source. | ||
| !filemap.lines.borrow().is_empty() && !filemap.is_imported() | ||
| }) | ||
| .map(|filemap| &**filemap)) |
There was a problem hiding this comment.
I think this is somewhere we can teach Rustfmt to be a bit smarter, but its not the end of the world IMO. More annoying to me is that the alignment of dots is misleading about the scope.
|
☔ The latest upstream changes (presumably #37301) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors: r+ |
|
📌 Commit ca83d02 has been approved by |
|
☔ The latest upstream changes (presumably #37292) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@nrc |
|
@bors: r+ |
|
📌 Commit 892a05d has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 26, 2016
run rustfmt on librustc_metadata folder
jseyfried
reviewed
Oct 27, 2016
| type_shorthands: Default::default(), | ||
| predicate_shorthands: Default::default() | ||
| }.encode_crate_root(); | ||
| opaque: opaque::Encoder::new(&mut cursor), |
There was a problem hiding this comment.
Strange indent (rustfmt bug?)
bors
added a commit
that referenced
this pull request
Oct 27, 2016
run rustfmt on librustc_metadata folder
This was referenced Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.