Commits on Nov 11, 2016

1. Don't hint to add lifetime on trait impl …

   Don't provide hint to add lifetime on impl items that implement a trait.
   
   ```rust
   use std::str::FromStr;
   
   pub struct Foo<'a> {
       field: &'a str,
   }
   
   impl<'a> FromStr for Foo<'a> {
       type Err = ();
       fn from_str(path: &str) -> Result<Self, ()> {
           Ok(Foo { field: path })
       }
   }
   ```
   
   would give the following hint:
   
   ```nocode
   help: consider using an explicit lifetime parameter as shown: fn from_str(path: &'a str) -> Result<Self, ()>
     --> <anon>:9:5
      |
   9  |     fn from_str(path: &str) -> Result<Self, ()> {
      |     ^
   ```
   
   which is never correct, since then there will be a lifetime mismatch
   between the impl and the trait.
   
   Remove this hint for impl items that implement a trait.

   

   estebank committed Nov 11, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 87b6d38
   • Browse repository at this point

   Copy the full SHA

   87b6d38 View commit details

   Browse the repository at this point in the history