-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICH: Hash expression spans if their source location is captured for panics. #37513
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,173 @@ | ||
| // Copyright 2016 The Rust Project Developers. See the COPYRIGHT | ||
| // file at the top-level directory of this distribution and at | ||
| // http://rust-lang.org/COPYRIGHT. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
| // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| // This test case tests the incremental compilation hash (ICH) implementation | ||
| // for exprs that can panic at runtime (e.g. because of bounds checking). For | ||
| // these expressions an error message containing their source location is | ||
| // generated, so their hash must always depend on their location in the source | ||
| // code, not just when debuginfo is enabled. | ||
|
|
||
| // The general pattern followed here is: Change one thing between rev1 and rev2 | ||
| // and make sure that the hash has changed, then change nothing between rev2 and | ||
| // rev3 and make sure that the hash has not changed. | ||
|
|
||
| // must-compile-successfully | ||
| // revisions: cfail1 cfail2 cfail3 | ||
| // compile-flags: -Z query-dep-graph -C debug-assertions | ||
|
|
||
| #![allow(warnings)] | ||
| #![feature(rustc_attrs)] | ||
| #![crate_type="rlib"] | ||
|
|
||
|
|
||
| // Indexing expression --------------------------------------------------------- | ||
| #[cfg(cfail1)] | ||
| pub fn indexing(slice: &[u8]) -> u8 { | ||
| slice[100] | ||
| } | ||
|
|
||
| #[cfg(not(cfail1))] | ||
| #[rustc_dirty(label="Hir", cfg="cfail2")] | ||
| #[rustc_clean(label="Hir", cfg="cfail3")] | ||
| #[rustc_metadata_dirty(cfg="cfail2")] | ||
| #[rustc_metadata_clean(cfg="cfail3")] | ||
| pub fn indexing(slice: &[u8]) -> u8 { | ||
| slice[100] | ||
| } | ||
|
|
||
|
|
||
| // Arithmetic overflow plus ---------------------------------------------------- | ||
| #[cfg(cfail1)] | ||
| pub fn arithmetic_overflow_plus(val: i32) -> i32 { | ||
| val + 1 | ||
| } | ||
|
|
||
| #[cfg(not(cfail1))] | ||
| #[rustc_dirty(label="Hir", cfg="cfail2")] | ||
| #[rustc_clean(label="Hir", cfg="cfail3")] | ||
| #[rustc_metadata_dirty(cfg="cfail2")] | ||
| #[rustc_metadata_clean(cfg="cfail3")] | ||
| pub fn arithmetic_overflow_plus(val: i32) -> i32 { | ||
| val + 1 | ||
| } | ||
|
|
||
|
|
||
| // Arithmetic overflow minus ---------------------------------------------------- | ||
| #[cfg(cfail1)] | ||
| pub fn arithmetic_overflow_minus(val: i32) -> i32 { | ||
| val - 1 | ||
| } | ||
|
|
||
| #[cfg(not(cfail1))] | ||
| #[rustc_dirty(label="Hir", cfg="cfail2")] | ||
| #[rustc_clean(label="Hir", cfg="cfail3")] | ||
| #[rustc_metadata_dirty(cfg="cfail2")] | ||
| #[rustc_metadata_clean(cfg="cfail3")] | ||
| pub fn arithmetic_overflow_minus(val: i32) -> i32 { | ||
| val - 1 | ||
| } | ||
|
|
||
|
|
||
| // Arithmetic overflow mult ---------------------------------------------------- | ||
| #[cfg(cfail1)] | ||
| pub fn arithmetic_overflow_mult(val: i32) -> i32 { | ||
| val * 2 | ||
| } | ||
|
|
||
| #[cfg(not(cfail1))] | ||
| #[rustc_dirty(label="Hir", cfg="cfail2")] | ||
| #[rustc_clean(label="Hir", cfg="cfail3")] | ||
| #[rustc_metadata_dirty(cfg="cfail2")] | ||
| #[rustc_metadata_clean(cfg="cfail3")] | ||
| pub fn arithmetic_overflow_mult(val: i32) -> i32 { | ||
| val * 2 | ||
| } | ||
|
|
||
|
|
||
| // Arithmetic overflow negation ------------------------------------------------ | ||
| #[cfg(cfail1)] | ||
| pub fn arithmetic_overflow_negation(val: i32) -> i32 { | ||
| -val | ||
| } | ||
|
|
||
| #[cfg(not(cfail1))] | ||
| #[rustc_dirty(label="Hir", cfg="cfail2")] | ||
| #[rustc_clean(label="Hir", cfg="cfail3")] | ||
| #[rustc_metadata_dirty(cfg="cfail2")] | ||
| #[rustc_metadata_clean(cfg="cfail3")] | ||
| pub fn arithmetic_overflow_negation(val: i32) -> i32 { | ||
| -val | ||
| } | ||
|
|
||
|
|
||
| // Division by zero ------------------------------------------------------------ | ||
| #[cfg(cfail1)] | ||
| pub fn division_by_zero(val: i32) -> i32 { | ||
| 2 / val | ||
| } | ||
|
|
||
| #[cfg(not(cfail1))] | ||
| #[rustc_dirty(label="Hir", cfg="cfail2")] | ||
| #[rustc_clean(label="Hir", cfg="cfail3")] | ||
| #[rustc_metadata_dirty(cfg="cfail2")] | ||
| #[rustc_metadata_clean(cfg="cfail3")] | ||
| pub fn division_by_zero(val: i32) -> i32 { | ||
| 2 / val | ||
| } | ||
|
|
||
| // Division by zero ------------------------------------------------------------ | ||
| #[cfg(cfail1)] | ||
| pub fn mod_by_zero(val: i32) -> i32 { | ||
| 2 % val | ||
| } | ||
|
|
||
| #[cfg(not(cfail1))] | ||
| #[rustc_dirty(label="Hir", cfg="cfail2")] | ||
| #[rustc_clean(label="Hir", cfg="cfail3")] | ||
| #[rustc_metadata_dirty(cfg="cfail2")] | ||
| #[rustc_metadata_clean(cfg="cfail3")] | ||
| pub fn mod_by_zero(val: i32) -> i32 { | ||
| 2 % val | ||
| } | ||
|
|
||
|
|
||
|
|
||
| // THE FOLLOWING ITEMS SHOULD NOT BE INFLUENCED BY THEIR SOURCE LOCATION | ||
|
|
||
| // bitwise --------------------------------------------------------------------- | ||
| #[cfg(cfail1)] | ||
| pub fn bitwise(val: i32) -> i32 { | ||
| !val & 0x101010101 | 0x45689 ^ 0x2372382 << 1 >> 1 | ||
| } | ||
|
|
||
| #[cfg(not(cfail1))] | ||
| #[rustc_clean(label="Hir", cfg="cfail2")] | ||
| #[rustc_clean(label="Hir", cfg="cfail3")] | ||
| #[rustc_metadata_clean(cfg="cfail2")] | ||
| #[rustc_metadata_clean(cfg="cfail3")] | ||
| pub fn bitwise(val: i32) -> i32 { | ||
| !val & 0x101010101 | 0x45689 ^ 0x2372382 << 1 >> 1 | ||
| } | ||
|
|
||
|
|
||
| // logical --------------------------------------------------------------------- | ||
| #[cfg(cfail1)] | ||
| pub fn logical(val1: bool, val2: bool, val3: bool) -> bool { | ||
| val1 && val2 || val3 | ||
| } | ||
|
|
||
| #[cfg(not(cfail1))] | ||
| #[rustc_clean(label="Hir", cfg="cfail2")] | ||
| #[rustc_clean(label="Hir", cfg="cfail3")] | ||
| #[rustc_metadata_clean(cfg="cfail2")] | ||
| #[rustc_metadata_clean(cfg="cfail3")] | ||
| pub fn logical(val1: bool, val2: bool, val3: bool) -> bool { | ||
| val1 && val2 || val3 | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, i'd forgotten about this, can we add this to the test?