Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking the 'no-stack-check' codegen option as deprecated (Issue #34915) #37636

Merged
merged 2 commits into from
Nov 9, 2016

Conversation

karpinski
Copy link
Contributor

Attempts to finish resolving issue #34915. Based on pull request #35156, which was closed due to inactivity.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -1011,6 +1011,10 @@ pub fn handle_options(args: &[String]) -> Option<getopts::Matches> {
return None;
}

if cg_flags.iter().any(|x| *x == "no-stack-check") {
println!("warning: the --no-stack-check flag is deprecated and does nothing");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of calling println! directly, it would be better to invoke early_warn, sort of like this code:

                    let msg = format!("the option `{}` is unstable and should \
                                       only be used on the nightly compiler, but \
                                       it is currently accepted for backwards \
                                       compatibility; this will soon change, \
                                       see issue #31847 for more details",
                                      opt_name);
                    early_warn(ErrorOutputType::default(), &msg);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nikomatsakis
Copy link
Contributor

Thanks for picking this up! See my suggestion above. =)

@nikomatsakis
Copy link
Contributor

Looks good to me! :)

@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2016

📌 Commit c670293 has been approved by nikomatsakis

eddyb added a commit to eddyb/rust that referenced this pull request Nov 9, 2016
Marking the 'no-stack-check' codegen option as deprecated (Issue rust-lang#34915)

Attempts to finish resolving issue rust-lang#34915. Based on pull request rust-lang#35156, which was closed due to inactivity.
bors added a commit that referenced this pull request Nov 9, 2016
Rollup of 15 pull requests

- Successful merges: #36868, #37134, #37229, #37250, #37370, #37428, #37432, #37472, #37524, #37614, #37622, #37627, #37636, #37644, #37654
- Failed merges: #37463, #37542, #37645
@bors bors merged commit c670293 into rust-lang:master Nov 9, 2016
@karpinski karpinski deleted the issue-34915 branch November 13, 2016 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants