Make Peekable remember peeking a None #37834
Merged
+109
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peekable must remember if a None has been seen in the `.peek()` method. It ensures that `.peek(); .peek();` or `.peek(); .next();` only advances the underlying iterator at most once. This does not by itself make the iterator fused.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
added
the
T-libs-api
bluss
changed the title
|
cc @rust-lang/libs I consider this a bug-fix, but it does involve changing the behavior of a stable API. |
|
👍 Would be cool to specialize for |
|
I'm 👍 for this change, sounds good to me! |
|
@bors: r+ |
|
📌 Commit 6c2a456 has been approved by |
bluss
added
the
relnotes
bors
added a commit
that referenced
this pull request
Nov 22, 2016
Make Peekable remember peeking a None Peekable should remember if a None has been seen in the `.peek()` method. It ensures that `.peek(); .peek();` or `.peek(); .next();` only advances the underlying iterator at most once. This does not by itself make the iterator fused. Thanks to @s3bk for the code in `fn peek()` itself. Fixes #37784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peekable should remember if a None has been seen in the
.peek()method.It ensures that
.peek(); .peek();or.peek(); .next();only advances theunderlying iterator at most once. This does not by itself make the iterator
fused.
Thanks to @s3bk for the code in
fn peek()itself.Fixes #37784