Document how lock 'guard' structures are created. #38010
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -134,6 +134,13 @@ unsafe impl<T: ?Sized + Send> Sync for Mutex<T> { } | |||
| /// | |||
| /// The data protected by the mutex can be access through this guard via its | |||
| /// `Deref` and `DerefMut` implementations | |||
There was a problem hiding this comment.
Not PR-bound but shouldn't be a dot present a the end of this sentence?
| @@ -77,6 +77,13 @@ unsafe impl<T: ?Sized + Send + Sync> Sync for RwLock<T> {} | |||
|
|
|||
| /// RAII structure used to release the shared read access of a lock when | |||
| /// dropped. | |||
| /// | |||
| /// This structure is created by the [`read()`] and [`try_read()`] methods on | |||
There was a problem hiding this comment.
Extra whitespace in "[read()] and".
frewsxcv
force-pushed
the
lock-creations
branch
from
f95e558 to
0e96f4a
Compare
|
Comments have been addressed. |
|
Now squash time! \o/ (just the last commit) |
Also, end sentence with a period.
frewsxcv
force-pushed
the
lock-creations
branch
from
0e96f4a to
6075af4
Compare
|
Thanks! @bors: r+ rollup |
|
📌 Commit 6075af4 has been approved by |
…eGomez Document how lock 'guard' structures are created.
No description provided.