Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update items section in reference #38130

Merged
merged 1 commit into from
Dec 4, 2016
Merged

Update items section in reference #38130

merged 1 commit into from
Dec 4, 2016

Conversation

jethrogb
Copy link
Contributor

@jethrogb jethrogb commented Dec 2, 2016

Make clear that items must be definitions, and add missing extern block

@jethrogb
Update items section in reference
ecf6f1b 
Make clear that items must be definitions, and add missing extern block
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you!

@bors
Copy link
Contributor

bors commented Dec 2, 2016

📌 Commit ecf6f1b has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 3, 2016
@frewsxcv
Rollup merge of rust-lang#38130 - jethrogb:patch-3, r=steveklabnik
02ad965 
Update items section in reference

Make clear that items must be definitions, and add missing extern block
@frewsxcv frewsxcv mentioned this pull request Dec 3, 2016
Merged
bors added a commit that referenced this pull request Dec 3, 2016
@bors
Auto merge of #38148 - frewsxcv:rollup, r=frewsxcv
28d6623 
Rollup of 15 pull requests

- Successful merges: #37859, #37919, #38020, #38028, #38029, #38065, #38073, #38077, #38089, #38090, #38096, #38112, #38113, #38130, #38141
- Failed merges:
@bors bors merged commit ecf6f1b into rust-lang:master Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jethrogb @rust-highfive @steveklabnik @bors