Fix unique pointers occuring in unreachable blocks #3825

jdm · 2012-10-21T07:48:03Z

It didn't take alignment into account. Fixes #3656.

DebugFlag is conditionally exported by LLVM in llvm/Support/Debug.h in-between an #ifndef NDEBUG block; RustWrapper should not unconditionally use it. This closes #3701. Signed-off-by: Luca Bruno <lucab@debian.org>

Parsing gpg output for signature verification is not recommended, as it can break easily (and doesn't work with i18n). This patch makes use of gpgv, as suggested by gpg authors: http://lists.gnupg.org/pipermail/gnupg-users/2004-August/023141.html This closes #3762. Signed-off-by: Luca Bruno <lucab@debian.org>

Also some work towards #3521 Closes #2428

Along the way, convert from dvec-of-dvec representation to track loans in scope to just a single flattened list. It's more convenient. Fixes #3765. r+ pcwalton.

Closes #3521

Previous commits fix the issue. Closes #3668

Closes #3214

Instead, replace with re_static. This was causing ty::subst to fail when called from trans::type_of::type_of. Already discussed with nmatsakis and it's a small change, so no review. Closes #3447

…entations.

rustc: fix size computation of structs for the FFI

libcore: add a str::with_capacity to match the fn in vec

Fix #3701: rustllvm conditional build

Use gpgv for signature verification in cargo

This also involves removing references to the old long-form closure syntax, which pcwalton alleges is deprecated and which was never updated for the new forms, e.g. `@fn() {}` is illegal.

…::expect Superficial change, no review.

This reenables valgrinding of the compiler and prints a message when the user _is_ valgrinding

`[int]/5` -> `[int * 5]`

Talk about ends, rather than means, in macro tutorial introduction.

fix a false positive in two `interior_mutable_const` lints where a constant with enums gets linted even if it uses a clearly unfrozen variant. Note that the code uses the MIR interpreter, which the author of rust-lang#3962 thought unlikely to be a solution. This might be over-engineering; but, I think it's important to be able to work with the 'http' crate (rust-lang#3825).

…=llogiq "Respect" enums in `interior_mutable_const` fixes rust-lang#3962 fixes rust-lang#3825 Hello, It might not be a good idea to submit another relatively large PR while I have an opened PR; but, I've finished this anyway. This may be able to wait for months. Note: the code uses the MIR interpreter, which the author of rust-lang#3962 thought unlikely to be a solution. This might be over-engineering; but, I think it's important to be able to work with the 'http' crate (rust-lang#3825). (And, I don't want to write a MIR visitor) --- changelog: fix a false positive in two `interior_mutable_const` lints where a constant with enums gets linted even if it uses a clearly unfrozen variant

epoll test_socketpair_read: explicitly check real and Miri behavior

erickt and others added 30 commits October 9, 2012 08:52

libcore: add a str::with_capacity to match the fn in vec

bdc1b7a

rustc: fix size computation of structs for the FFI

25096a2

It didn't take alignment into account. Fixes #3656.

Conditional usage of LLVM DebugFlag

97ecde2

DebugFlag is conditionally exported by LLVM in llvm/Support/Debug.h in-between an #ifndef NDEBUG block; RustWrapper should not unconditionally use it. This closes #3701. Signed-off-by: Luca Bruno <lucab@debian.org>

libstd: make Serializer a trait-level typaram

ab89b5c

Add various test cases (xfailed)

f6211ab

Allow enum discriminator exprs to refer to declared consts

7237268

Also some work towards #3521 Closes #2428

Fix whitespace

0643466

Check whether loans conflict with old loans or with themselves.

2a1aa9f

Along the way, convert from dvec-of-dvec representation to track loans in scope to just a single flattened list. It's more convenient. Fixes #3765. r+ pcwalton.

rustc: Implement monomorphic default methods. r=nmatsakis

c886629

Un-xfail test for #3521; it works now

4f9e7ba

Closes #3521

Add test cases for #3668

c5b82a6

Previous commits fix the issue. Closes #3668

rustc: Merge module and type namespaces. r=brson

91ae541

Error out in resolve if structs try to capture type parameters

7d84505

Closes #3214

Add test case for Issue 2895

d293286

Add test for Issue 2823

bbc46d5

In ty::normalize_ty, don't replace self_regions with None

b38092e

Instead, replace with re_static. This was causing ty::subst to fail when called from trans::type_of::type_of. Already discussed with nmatsakis and it's a small change, so no review. Closes #3447

rustc: Implement intra-crate static methods on anonymous trait implem…

4dc67c5

…entations.

add missing pub from multifile example in sec 12.3

a92c3db

Change a use of map::get to map::find

1679960

Remove integer suffixes

081a043

Export std::net_url::encode_component

47c83f1

Merge pull request #3716 from Blei/fix-3656

7f12cc4

rustc: fix size computation of structs for the FFI

Merge pull request #3706 from erickt/str-with-capacity

ebce097

libcore: add a str::with_capacity to match the fn in vec

Merge pull request #3719 from lucab/lucab/to-upstream/pull-2

f5e71f5

Fix #3701: rustllvm conditional build

Merge pull request #3764 from lucab/lucab/to-upstream/pull-3

5cf0c65

Use gpgv for signature verification in cargo

Extraneous sigil patrol: ~"string literals"

e94e82c

Sigil patrol: change fn@ fn& fn~ to @fn &fn ~fn

5e1d0ba

This also involves removing references to the old long-form closure syntax, which pcwalton alleges is deprecated and which was never updated for the new forms, e.g. `@fn() {}` is illegal.

Extraneous sigil patrol: turn &[] literals into []

f7ce3dc

fix the indentation of foreign constant

ca5506a

catamorphism and others added 26 commits October 19, 2012 11:38

Remove superfluous by-ref in option::get, option::get_default, option…

10612ee

…::expect Superficial change, no review.

Fix Windows breakage

8492a02

Renaming trait name UniqueStr to Trimmable

81e66ae

Add Mahmut Bulut to AUTHORS

0243d86

core: add 3rd proposed interface (trap/in) to conditions.

89de49c

Valgrind check disable

c05d96c

Some tweaks to the valgrind makefile code

55d134d

This reenables valgrinding of the compiler and prints a message when the user _is_ valgrinding

Fix run-pass/issue-2895 for 32-bit archs

15777de

uv: implement a way to get client's ip/port.

0e2437b

uv: use just getpeername for both ipv4 and ipv6.

79e538d

std: Add test for getpeername

781f8cb

std: rename getpeername to get_peer_addr

9555ee7

std: Use unique ports in tcp tests

8dd8136

Add new uv functions to rustrt.def.in

55e40a1

libsyntax: adapt the pretty printer for the new fixed size array syntax

4174688

`[int]/5` -> `[int * 5]`

Remove old fixed-length vector syntax

ac81fff

Fix a pprint test for fixed-length vecs

684d945

No longer parse old fixed-length vec sytnax

614624a

...missed a merge marker on that last rebase

41c37d9

Parse and report obsolete fixed-length vector syntax

f3df50f

Remove remaining uses of old fixed-length vec syntax

8a8fbe3

Remove obsolete fixed-length string test

8378757

Long lines

9980f25

std: Shuffle around test ports some more

191d162

Talk about ends, rather than means, in macro tutorial introduction.

4edb881

Merge pull request #3823 from paulstansifer/master

082d3d5

Talk about ends, rather than means, in macro tutorial introduction.

jdm closed this Oct 21, 2012

RalfJung pushed a commit to RalfJung/rust that referenced this pull request Aug 18, 2024

Auto merge of rust-lang#3825 - RalfJung:epoll-miri, r=RalfJung

8f2768b

epoll test_socketpair_read: explicitly check real and Miri behavior

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix unique pointers occuring in unreachable blocks #3825

Fix unique pointers occuring in unreachable blocks #3825

jdm commented Oct 21, 2012

Fix unique pointers occuring in unreachable blocks #3825

Fix unique pointers occuring in unreachable blocks #3825

Conversation

jdm commented Oct 21, 2012