-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redox Cross Compilation #38401
Redox Cross Compilation #38401
Changes from all commits
341d2d1
c7aa284
a621d12
d2707aa
ece703a
f86e014
3e7543a
773a0a2
07e313d
6d7c2ec
57bc1a9
86f85c1
01157e6
e55596f
65eecf8
fd4bc88
7697c72
2ca1f0b
bf50acb
e909e43
92c8e0f
7d3ae87
e7b006d
1eb6c44
2ddd117
474eb62
c59bb49
4dcb867
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# rustbuild-only target | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,7 +36,8 @@ fn main() { | |
// targets, which means we have to build the alloc_jemalloc crate | ||
// for targets like emscripten, even if we don't use it. | ||
if target.contains("rumprun") || target.contains("bitrig") || target.contains("openbsd") || | ||
target.contains("msvc") || target.contains("emscripten") || target.contains("fuchsia") { | ||
target.contains("msvc") || target.contains("emscripten") || target.contains("fuchsia") || | ||
target.contains("redox") { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do not support jemalloc, so we will build with the dummy. |
||
println!("cargo:rustc-cfg=dummy_jemalloc"); | ||
return; | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ | |
issue = "27783")] | ||
#![feature(allocator)] | ||
#![feature(staged_api)] | ||
#![cfg_attr(unix, feature(libc))] | ||
#![cfg_attr(any(unix, target_os = "redox"), feature(libc))] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For |
||
|
||
// The minimum alignment guaranteed by the architecture. This value is used to | ||
// add fast paths for low alignment values. In practice, the alignment is a | ||
|
@@ -71,7 +71,7 @@ pub extern "C" fn __rust_usable_size(size: usize, align: usize) -> usize { | |
imp::usable_size(size, align) | ||
} | ||
|
||
#[cfg(unix)] | ||
#[cfg(any(unix, target_os = "redox"))] | ||
mod imp { | ||
extern crate libc; | ||
|
||
|
@@ -87,7 +87,7 @@ mod imp { | |
} | ||
} | ||
|
||
#[cfg(target_os = "android")] | ||
#[cfg(any(target_os = "android", target_os = "redox"))] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Newlib does not contain |
||
unsafe fn aligned_malloc(size: usize, align: usize) -> *mut u8 { | ||
// On android we currently target API level 9 which unfortunately | ||
// doesn't have the `posix_memalign` API used below. Instead we use | ||
|
@@ -109,7 +109,7 @@ mod imp { | |
libc::memalign(align as libc::size_t, size as libc::size_t) as *mut u8 | ||
} | ||
|
||
#[cfg(not(target_os = "android"))] | ||
#[cfg(not(any(target_os = "android", target_os = "redox")))] | ||
unsafe fn aligned_malloc(size: usize, align: usize) -> *mut u8 { | ||
let mut out = ptr::null_mut(); | ||
let ret = libc::posix_memalign(&mut out, align as libc::size_t, size as libc::size_t); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -943,26 +943,20 @@ pub fn default_configuration(sess: &Session) -> ast::CrateConfig { | |
let vendor = &sess.target.target.target_vendor; | ||
let max_atomic_width = sess.target.target.max_atomic_width(); | ||
|
||
let fam = if let Some(ref fam) = sess.target.target.options.target_family { | ||
Symbol::intern(fam) | ||
} else if sess.target.target.options.is_like_windows { | ||
Symbol::intern("windows") | ||
} else { | ||
Symbol::intern("unix") | ||
}; | ||
|
||
let mut ret = HashSet::new(); | ||
// Target bindings. | ||
ret.insert((Symbol::intern("target_os"), Some(Symbol::intern(os)))); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the windows platforms now correctly define target_family, this is no longer necessary. |
||
ret.insert((Symbol::intern("target_family"), Some(fam))); | ||
if let Some(ref fam) = sess.target.target.options.target_family { | ||
ret.insert((Symbol::intern("target_family"), Some(Symbol::intern(fam)))); | ||
if fam == "windows" || fam == "unix" { | ||
ret.insert((Symbol::intern(fam), None)); | ||
} | ||
} | ||
ret.insert((Symbol::intern("target_arch"), Some(Symbol::intern(arch)))); | ||
ret.insert((Symbol::intern("target_endian"), Some(Symbol::intern(end)))); | ||
ret.insert((Symbol::intern("target_pointer_width"), Some(Symbol::intern(wordsz)))); | ||
ret.insert((Symbol::intern("target_env"), Some(Symbol::intern(env)))); | ||
ret.insert((Symbol::intern("target_vendor"), Some(Symbol::intern(vendor)))); | ||
if fam == "windows" || fam == "unix" { | ||
ret.insert((fam, None)); | ||
} | ||
if sess.target.target.options.has_elf_tls { | ||
ret.insert((Symbol::intern("target_thread_local"), None)); | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,7 @@ pub fn opts() -> TargetOptions { | |
function_sections: false, | ||
dynamic_linking: true, | ||
executables: true, | ||
target_family: Some("unix".to_string()), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Everything that isn't windows, is set to unix. That includes Linux, OS X, iOS, DragonflyBSD, NetBSD, OpenBSD, FreeBSD, Bitrig, Solaris, Fuchsia, and Haiku |
||
is_like_osx: true, | ||
has_rpath: true, | ||
dll_prefix: "lib".to_string(), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,6 +69,7 @@ mod windows_base; | |
mod windows_msvc_base; | ||
mod thumb_base; | ||
mod fuchsia_base; | ||
mod redox_base; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We must add a new OS base for Redox |
||
|
||
pub type TargetResult = Result<Target, String>; | ||
|
||
|
@@ -184,6 +185,8 @@ supported_targets! { | |
("aarch64-unknown-fuchsia", aarch64_unknown_fuchsia), | ||
("x86_64-unknown-fuchsia", x86_64_unknown_fuchsia), | ||
|
||
("x86_64-unknown-redox", x86_64_unknown_redox), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We support a single architecture for Redox, |
||
|
||
("i386-apple-ios", i386_apple_ios), | ||
("x86_64-apple-ios", x86_64_apple_ios), | ||
("aarch64-apple-ios", aarch64_apple_ios), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
use PanicStrategy; | ||
use target::TargetOptions; | ||
use std::default::Default; | ||
|
||
pub fn opts() -> TargetOptions { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This target is a bit different from others. Redox does not link to a |
||
TargetOptions { | ||
pre_link_args: vec![ | ||
// We want to be able to strip as much executable code as possible | ||
// from the linker command line, and this flag indicates to the | ||
// linker that it can avoid linking in dynamic libraries that don't | ||
// actually satisfy any symbols up to that point (as with many other | ||
// resolutions the linker does). This option only applies to all | ||
// following libraries so we're sure to pass it as one of the first | ||
// arguments. | ||
"-Wl,--as-needed".to_string(), | ||
|
||
// Always enable NX protection when it is available | ||
"-Wl,-z,noexecstack".to_string(), | ||
|
||
// Static link | ||
"-static".to_string() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redox does not support dynamic linking, so all files should be linked statically. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe we've recently added support for |
||
], | ||
late_link_args: vec![ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We late link libc and libm so that they can be provided when binaries are linked, rather than using the compiler defaults. |
||
"-lc".to_string(), | ||
"-lm".to_string() | ||
], | ||
executables: true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We are able to generate executables. This is done rather unhygienically in |
||
relocation_model: "static".to_string(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no support for relocation in Redox. |
||
disable_redzone: true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Red zones are not currently supported by Redox. This may be enabled in the future after testing. |
||
eliminate_frame_pointer: false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do not eliminate the frame pointer so that stack frames are easily traversable. |
||
target_family: None, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redox no longer has a family :-( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😢 |
||
linker_is_gnu: true, | ||
no_default_libraries: true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No default libraries must be linked, as they would come from the host. |
||
lib_allocation_crate: "alloc_system".to_string(), | ||
exe_allocation_crate: "alloc_system".to_string(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We use |
||
has_elf_tls: true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do support TLS, so we enable it. |
||
panic_strategy: PanicStrategy::Abort, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do not support unwinding, so we panic using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unwinding is not supported at the moment, so we abort. |
||
.. Default::default() | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,7 @@ pub fn opts() -> TargetOptions { | |
staticlib_prefix: "".to_string(), | ||
staticlib_suffix: ".lib".to_string(), | ||
no_default_libraries: true, | ||
target_family: Some("windows".to_string()), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Both the windows bases are covered |
||
is_like_windows: true, | ||
allows_weak_linkage: false, | ||
pre_link_args: vec![ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
use target::{Target, TargetResult}; | ||
|
||
pub fn target() -> TargetResult { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These settings are very similar to those in other targets, and are nothing special. |
||
let mut base = super::redox_base::opts(); | ||
base.cpu = "x86-64".to_string(); | ||
base.max_atomic_width = Some(64); | ||
base.pre_link_args.push("-m64".to_string()); | ||
|
||
Ok(Target { | ||
llvm_target: "x86_64-unknown-redox".to_string(), | ||
target_endian: "little".to_string(), | ||
target_pointer_width: "64".to_string(), | ||
data_layout: "e-m:e-i64:64-f80:128-n8:16:32:64-S128".to_string(), | ||
arch: "x86_64".to_string(), | ||
target_os: "redox".to_string(), | ||
target_env: "".to_string(), | ||
target_vendor: "unknown".to_string(), | ||
options: base, | ||
}) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ fn main() { | |
let target = env::var("TARGET").expect("TARGET was not set"); | ||
let host = env::var("HOST").expect("HOST was not set"); | ||
if cfg!(feature = "backtrace") && !target.contains("apple") && !target.contains("msvc") && | ||
!target.contains("emscripten") && !target.contains("fuchsia") { | ||
!target.contains("emscripten") && !target.contains("fuchsia") && !target.contains("redox") { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We disable the build of |
||
build_libbacktrace(&host, &target); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old build system is complicated to use, so there is no support for using it.