rustbuild: Delete extraneous pretty test suites #38420
Conversation
The pretty printer in the compiler isn't really heavily used, and there's not really many stability guarantees around it. In that sense we don't need to exhaustively test it on every single build of Rust. Additionally these test suites typically take around 10-15 minutes of each CI run, which certainly adds up over time. This commit deletes the pretty passes over the standard test suites, e.g. run-pass, run-pass-fulldeps, etc. The `src/test/pretty` folder is still kept and we can retain test cases there, but this should cut down on the vast majority of pretty test case related test time.
|
r? @brson |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Oh it's on. |
|
Pass rate for pretty printing tests is in relatively good state now, I recently fixed and enabled many previously failing tests and the few remaining tests are covered by issues #37195, #37199, #37201. cc @nrc |
|
Ah so I should clarify that I'm currently under the impression that we use the pretty printer very little, if at all, in the compiler. Please correct me if I'm wrong though! If it's critical that the pretty printer works in every way possible then we should keep testing everything, of course. |
|
The pretty printer is used for example to print arbitrary expressions generated by procedural macros, in error messages. I'd prefer to keep running pretty on the 'pretty' tests and the 'run-pass' tests, but punt them to the cargotest bot (maybe renaming cargotest to 'aux' or something), so they don't compete for ci time. We can have a single aux test target that tests these minor things that should be tested, but shouldn't break. |
|
I'm in favor of removing pretty entirely, but I remember @erickt saying "nooooooooo" |
|
@brson ok that approach seems reasonable to me, I'll close this and reopen with that strategy. |
The pretty printer in the compiler isn't really heavily used, and there's not
really many stability guarantees around it. In that sense we don't need to
exhaustively test it on every single build of Rust. Additionally these test
suites typically take around 10-15 minutes of each CI run, which certainly adds
up over time.
This commit deletes the pretty passes over the standard test suites, e.g.
run-pass, run-pass-fulldeps, etc. The
src/test/prettyfolder is still kept andwe can retain test cases there, but this should cut down on the vast majority of
pretty test case related test time.